Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57983C64EC7 for ; Wed, 1 Mar 2023 02:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbjCACXE (ORCPT ); Tue, 28 Feb 2023 21:23:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjCACXC (ORCPT ); Tue, 28 Feb 2023 21:23:02 -0500 Received: from out-15.mta1.migadu.com (out-15.mta1.migadu.com [IPv6:2001:41d0:203:375::f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61BF112F3D for ; Tue, 28 Feb 2023 18:23:01 -0800 (PST) Date: Wed, 1 Mar 2023 10:22:53 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677637377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjfrdvJ5EsT0YAy1o3AET9M3uaWnQUjK9n1xqYiKKqI=; b=ZFXZDpPnzIeQyQPyopzXCeCoC1mkMkXU8UcQM1hTChwqORjbga7wiPKXPpidve6XUGscqM fQs+AXb1Z5HNbO/mV3bCbstCvjWzgrpZxEyrajLZw54msNo26fkgmuqizhu18ygxhVQ1kS 5cyqVzY61WkjZGpnvEYJFrCGMYxBAAI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Cai Huoqing To: fancer.lancer@gmail.com Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v4 0/4] dmaengine: dw-edma: Add support for native HDMA Message-ID: References: <20230221034656.14476-1-cai.huoqing@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230221034656.14476-1-cai.huoqing@linux.dev> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 2月 23 11:46:51, Cai Huoqing wrote: > Add support for HDMA NATIVE, as long the IP design has set > the compatible register map parameter-HDMA_NATIVE, > which allows compatibility for native HDMA register configuration. > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > And the native HDMA registers are different from eDMA, > so this patch add support for HDMA NATIVE mode. > > HDMA write and read channels operate independently to maximize > the performance of the HDMA read and write data transfer over > the link When you configure the HDMA with multiple read channels, > then it uses a round robin (RR) arbitration scheme to select > the next read channel to be serviced.The same applies when > youhave multiple write channels. > > The native HDMA driver also supports a maximum of 16 independent > channels (8 write + 8 read), which can run simultaneously. > Both SAR (Source Address Register) and DAR (Destination Address Register) > are aligned to byte. Just ping this patch v4 Thanks, Cai- > > Cai huoqing (4): > dmaengine: dw-edma: Rename dw_edma_core_ops structure to > dw_edma_plat_ops > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to > abstract controller operation > dmaengine: dw-edma: Add support for native HDMA > dmaengine: dw-edma: Add HDMA DebugFS support > > v3->v4: > [1/4] > 1.Update the structure name dw_edma_plat_ops in commit log > 2.Fix code stytle. > [2/4] > 3.Refactor dw_edma_interrupt() and related callbacks to > make the code more readable, the calls hierarchy like this: > > irq: dw_edma_interrupt_{write,read}() > +-> dw_edma_core_handle_int() (dw-edma-v0-core.c) > +-> dw_edma_v0_core_status_done_int() (dw-edma-v0-core.c) > +-> dw_edma_v0_core_clear_done_int() (dw-edma-v0-core.c) > +-> dw_edma_done_interrupt() (dw-edma-core.c) > +-> dw_edma_v0_core_status_abort_int() (dw-edma-v0-core.c) > +-> dw_edma_v0_core_clear_abort_int() (dw-edma-v0-core.c) > +-> dw_edma_abort_interrupt() (dw-edma-core.c) > 4.Use the dw_edma_v0_core name for the dw_edma_core_ops structure instance. > [3/4] > 5.Fix weird indentation of control1, func_num, etc. > 6.Include 'linux/io-64-nonatomic-lo-hi.h' to fix warning. > 7.Refactor dw_edma_core_handle_int related callback in dw_hdma_v0_core ops. > [4/4] > 8.Add field watermark_en, func_num, qos, msi_watermark,etc. > 9.Make variables reverse xmas tree order. > 10.Declare const for 'struct dw_hdma_debugfs_entry' > > v3 link: > https://lore.kernel.org/lkml/20230213132411.65524-1-cai.huoqing@linux.dev/ > > drivers/dma/dw-edma/Makefile | 8 +- > drivers/dma/dw-edma/dw-edma-core.c | 77 ++--- > drivers/dma/dw-edma/dw-edma-core.h | 56 ++++ > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +- > drivers/dma/dw-edma/dw-edma-v0-core.c | 73 ++++- > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 302 +++++++++++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 181 +++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++ > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++ > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > include/linux/dma/edma.h | 7 +- > 13 files changed, 807 insertions(+), 85 deletions(-) > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h > > -- > 2.34.1 >