From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     Matthias Kaehlcke <mka@chromium.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Stanimir Varbanov <svarbanov@mm-sol.com>,
        linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v1 00/15] create power sequencing subsystem
Date:   Wed, 01 Mar 2023 09:17:50 +0100
Message-ID: <10237323.nUPlyArG6x@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <CAA8EJppuGbDGb1D-yf2WL77U1bqx1QQStQeDArWmGFCUiOtnww@mail.gmail.com>
References: <20211006035407.1147909-1-dmitry.baryshkov@linaro.org> <Y0hr9XTGAg8Q6K6y@google.com> <CAA8EJppuGbDGb1D-yf2WL77U1bqx1QQStQeDArWmGFCUiOtnww@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi,

sorry for being late to the party.

Am Mittwoch, 19. Oktober 2022, 08:03:22 CET schrieb Dmitry Baryshkov:
> Ho,
>=20
> On Thu, 13 Oct 2022 at 22:50, Matthias Kaehlcke <mka@chromium.org> wrote:
> > Do you still plan to refresh this series?
> >=20
> > I know there have been multiple attempts to get something similar
> > landed in the past 10 year or so. Your series didn't seem to get
> > much pushback from maintainers, might be worth sending a refresh :)
>=20
> Yes, I hope to return to it eventually. I just had no time for it lately.

I just found this thread while searching for power sequencing devices in=20
Linux. From what I understand this is transforming the existing mmc pwrseq=
=20
drivers into generic ones. What is the intention of this new subsystem? Wha=
t=20
is it supposed to address?
In my case I have an LTE module attached via USB, but in order to use it I=
=20
need to perform several steps:
1. apply power supply
2. Issue a reset pulse(!), the length actually defines whether its a reset =
or=20
poweroff/on
3a. wait for a GPIO to toggle
3b. wait a minimum time
4a. device will enumerate on USB
4b. device can be access using UART

This is something required to actually see/detect the device in the first=20
place, thus it cannot be part of the device driver side.
Is this something pwrseq is supposed to address?

Best regards,
Alexander

> > On Wed, Oct 06, 2021 at 06:53:52AM +0300, Dmitry Baryshkov wrote:
> > > This is a proposed power sequencer subsystem. This is a
> > > generification of the MMC pwrseq code. The subsystem tries to abstract
> > > the idea of complex power-up/power-down/reset of the devices.
> > >=20
> > > The primary set of devices that promted me to create this patchset is
> > > the Qualcomm BT+WiFi family of chips. They reside on serial+platform
> > > or serial + SDIO interfaces (older generations) or on serial+PCIe (ne=
wer
> > > generations).  They require a set of external voltage regulators to be
> > > powered on and (some of them) have separate WiFi and Bluetooth enable
> > > GPIOs.
> > >=20
> > > The major drawback for now is the lack of proper PCIe integration
> > > At this moment support for PCIe is hacked up to be able to test the
> > > PCIe part of qca6390. Proper PCIe support would require automatically
> > > powering up the devices before the scan basing on the proper device
> > > structure in the device tree. This two last patches are noted as WIP =
and
> > > are included into the patchset for the purpose of testing WiFi on new=
er
> > > chips (like qca6390/qca6391).
> > >=20
> > > Changes since RFC v2:
> > >  - Add documentation for the pwrseq code. Document data structures,
> > > =20
> > >    macros and exported functions.
> > > =20
> > >  - Export of_pwrseq_xlate_onecell()
> > >  - Add separate pwrseq_set_drvdata() function to follow the typical A=
PI
> > > =20
> > >    design
> > > =20
> > >  - Remove pwrseq_get_optional()/devm_pwrseq_get_optional()
> > >  - Moved code to handle old mmc-pwrseq binding to the MMC patch
> > >  - Split of_pwrseq_xlate_onecell() support to a separate patch
> > >=20
> > > Changes since RFC v1:
> > >  - Provider pwrseq fallback support
> > >  - Implement fallback support in pwrseq_qca.
> > >  - Mmove susclk handling to pwrseq_qca.
> > >  - Significantly simplify hci_qca.c changes, by dropping all legacy
> > > =20
> > >    code. Now hci_qca uses only pwrseq calls to power up/down bluetooth
> > >    parts of the chip.
> > >=20
> > > _______________________________________________
> > > ath10k mailing list
> > > ath10k@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/ath10k


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/