MIME-Version: 1.0
References: <20230228175929.7534-1-ubizjak@gmail.com> <20230228175929.7534-2-ubizjak@gmail.com>
 <20230301075519.dbf770fed0476e2b6ecdad37@kernel.org>
In-Reply-To: <20230301075519.dbf770fed0476e2b6ecdad37@kernel.org>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Wed, 1 Mar 2023 09:46:50 +0100
Message-ID: <CAFULd4b0zQSzesH3mrbtThH17VnoPzVhg2R6cDpDZTMsPeDWpQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] ring_buffer: Change some static functions to void
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 28, 2023 at 11:55 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Tue, 28 Feb 2023 18:59:27 +0100
> Uros Bizjak <ubizjak@gmail.com> wrote:
>
> > The results of some static functions are not used. Change the
> > type of these function to void and remove unnecessary returns.
> >
> > No functional change intended.
>
> NAK, instead of dropping the errors, please handle it on the caller side.

I was under the impression that the intention of these two functions
is to warn if there is any corruption in data pages detected. Please
note that the patch has no effect on code size, as the compiler is
smart enough to drop unused return values by itself. So, the change is
mostly cosmetic as I was just bothered by unused returns. I'm not
versed enough in the code to introduce additional error handling, so
considering its minimal impact, the patch can just be dropped.

Uros.