Date:   Wed, 1 Mar 2023 10:54:41 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Lee Jones <lee@kernel.org>
Cc:     Martin Kurbanov <mmkurbanov@sberdevices.ru>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v2 2/2] leds: add aw20xx driver
Message-ID: <Y/8g4QfOJhjc4WMb@amd.ucw.cz>
References: <20230228211046.109693-1-mmkurbanov@sberdevices.ru>
 <20230228211046.109693-3-mmkurbanov@sberdevices.ru>
 <Y/5xBGFC3b9Chdtb@duo.ucw.cz>
 <Y/8TTRtoFMJhMWV1@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="goqUx+bIZeqxo/gA"
Content-Disposition: inline
In-Reply-To: <Y/8TTRtoFMJhMWV1@google.com>
Precedence: bulk


--goqUx+bIZeqxo/gA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > > +config LEDS_AW200XX
> > > +	tristate "LED support for Awinic AW20036/AW20054/AW20072"
> > > +	depends on LEDS_CLASS
> > > +	depends on I2C
> > > +	help
> > > +	  This option enables support for the AW20036/AW20054/AW20072 LED d=
river.
> > > +	  It is a 3x12/6x9/6x12 matrix LED driver programmed via
> > > +	  an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> > > +	  3 pattern controllers for auto breathing or group dimming control.
> >=20
> > I'm afraid this should be handled as a display, not as an array of
> > individual LEDs.
>=20
> Just for my own information, where do we draw the line on this?

Not sure.

> Is 4x4 okay?  How about 6x6?

I'd say "As soon as it is 2-dimensional". Even 3x2 array is a display.

If the LEDs are independend, and it makes sense to display disk
activity on one and CPU activity on second... that's for LED
subsystem.

When userspace needs to know where are the LEDs spatially located, and
when you start putting synchronized animations over the LEDs... well,
then maybe that's a display.

6x9 is definitely a display. We won't put 1920x1080 phone display into
drivers/leds just because it is OLED...

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--goqUx+bIZeqxo/gA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY/8g4QAKCRAw5/Bqldv6
8rn/AJwJKp+LFn7p0CTmoaCYrBHRmH9mcgCfRz4lkROBbFHq5QhMvcz1xOmoiDI=
=MGxO
-----END PGP SIGNATURE-----

--goqUx+bIZeqxo/gA--