Date:   Wed, 1 Mar 2023 11:39:13 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable
 bcntime_cfg
Message-ID: <Y/8rUTtuzcgp34KQ@corigine.com>
References: <20230228021132.88910-1-jiapeng.chong@linux.alibaba.com>
 <Y/3gUquaPNlaLaKt@corigine.com>
 <1d262829764d40a086e93f0c7d0541bc@realtek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1d262829764d40a086e93f0c7d0541bc@realtek.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yE5KkApZWfEaSLI5JnokKoY6dPAFX9y7l4YjerBAK546pyJz2JDXGwiVeTj8?=
 =?us-ascii?Q?7S6wo8NvzuB92sQPud+WycKHA+UTmEMUNmb3WK69TB5Xmct8gy5QiEVM6goJ?=
 =?us-ascii?Q?nEOhN4OrmwDkORE5sMuuDeP+FBTwlVGnrz7liBSfryq2JA7X8YBuftKXo/TC?=
 =?us-ascii?Q?lLHFzMoexL17qOdd/P/OXmcoxsxKECG8qXS4SpsR/c4CPvRQ1EWqytm6NgZH?=
 =?us-ascii?Q?qSXd6MucNXZiGMH3X3PqOPV4OMTm5by5FuJAJt9eHIZr5VmOabvhYn1rmrcC?=
 =?us-ascii?Q?DvqMt6qMhMdYCIDYhol67OqCz11xr6bTLTOIKOEN4JsjL31priEzZJ9r7XrI?=
 =?us-ascii?Q?9F0ukMCyD/4OXuAQLs9vbHTack7sPoTbyfQmnqyoR+jZs2p6C0qjjG0/dxbS?=
 =?us-ascii?Q?YKfOlUi6wmHZQNBz3jixr/4jn2nP5cG59TzymAFwDDsUczlGM+r1+TqAv7s2?=
 =?us-ascii?Q?ors3kIBic+LFOpZtTOWsVx54XvI3SagU6HHuNV8q29iZ+Uw2+1VC/MQs4tea?=
 =?us-ascii?Q?kofj9uS13v340jIJdDLoMJNDaOVhgoBUUFlQUWgltGHTmGm8zPbTuNRKGwsO?=
 =?us-ascii?Q?i4EazSRfGDjB9zwIkxWZmyaM4DIlLyAsIkvmzN58I7R4RxstEGvz3Ycm2LBr?=
 =?us-ascii?Q?1dBTPWCKtvdnO9Svfm54G/qU/74Lhtyt6VrQlxqThw4mDIhUZciqGUI961BX?=
 =?us-ascii?Q?88R4ITOIvshnRLOWB4PRDi/r1pQ4/JaEZTOQCQniB23MA2KV5A01xicq5PNu?=
 =?us-ascii?Q?my8Ry3m42vL08ifx3sv9tBfod63GpMWh/OgS4tFd1wvJND7SdxyyB6JNOyTP?=
 =?us-ascii?Q?fAnDx8g8yH6UMB6f7z+ktC62D24+feXgbcrn4qXPontRDICqhMSePrzTUoSh?=
 =?us-ascii?Q?g1fpLcJc9IjzCA2pBH0PBLKXFypNgs53J1e8ye9r3ucn3aeDnkxLlrd7E2LY?=
 =?us-ascii?Q?xObV3+20HMdImCdK9WCqMflg4b+4nWT5vW9SaiHESvq+WUoiKos6JVSxU98m?=
 =?us-ascii?Q?PuOkvcpiqFbZAJOEVe6TRqmSf8Zv+QpQje5xs0F1RcAvK4a4H2hCQcfYm/y1?=
 =?us-ascii?Q?H7djWrdoJOCzfRVNYh4joT0u3A7GFz+sCWC1k/cBn1+iTXVu1+SIfJllX+t7?=
 =?us-ascii?Q?RQRr3dyR4SBJuGNEQynDIOUgxoNvoG5yPm1Mf8ys6/pxIEzZWUFbGzKAglsQ?=
 =?us-ascii?Q?YcxVbE8zZjzqKOhflPFbfe7IxtctHKi/eUG0gR00e2yI0hpcfEO3QPlz0vnj?=
 =?us-ascii?Q?wTMyKTTLYdIaj8rqNU6vylvPnrZmurO69Yzs5HJq1Eu6rrWBzZxejgv3oGkb?=
 =?us-ascii?Q?0cneQKcNs/08R1Ua8Q+FG5rxgcoktYz+dW9/8YWo0NSu/GjEFifxQIPj0oi0?=
 =?us-ascii?Q?pNeC1p6JAh9C7qC26AEv+w04zcvnQG6DOmmq+kBITASfSibYJVKh2MrEZl5e?=
 =?us-ascii?Q?GNO0kKr+nJfcfevsFfAAJlHZudkPyKEEYB5XkmdP3xDS19SWOu10ygcpS3HM?=
 =?us-ascii?Q?uEe2N/vg78rBSW8ngxCvEzTfNruJRnQb5HbgwugH+DZQ3imp7hEN0vnY3x0p?=
 =?us-ascii?Q?AqgRiz6ocZl8+w8Otl0bV0gT13QpBy855YBjo1+QRrIoMVX/hMyd67s+zidd?=
 =?us-ascii?Q?+b606Ia0RGIsUpy4JHlhW5rEtkc1p9aUUFyew485BO8tGEBkuOyDpboHrcke?=
 =?us-ascii?Q?Wwmeyg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a406bd20-7fe5-4916-51b0-08db1a41374f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 10:39:20.9804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40OKCuZyQH6Takw8XdnILFyY98ZhFZwn81lPBw+74J7nGoo6DhBltG9MyA55qHZthKkkkUJ8PptrpkmQEl6kchYs/Tc9mzJKShHlIlMwi8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5517
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 01, 2023 at 12:32:38AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine.com>
> > Sent: Tuesday, February 28, 2023 7:07 PM
> > To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; davem@davemloft.net; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Abaci Robot <abaci@linux.alibaba.com>
> > Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime_cfg
> > 
> > On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote:
> > > Variable bcntime_cfg is not effectively used, so delete it.
> > >
> > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not
> > used.
> > >
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > 
> > Hi Jiapeng Chong,
> > 
> > this looks good to me.
> > 
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> > 
> > While reviewing this gcc 12.2.0 told me:
> > 
> > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs'
> > [-Werror=unused-variable]
> >  1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
> >       |                         ^~~~~~~
> > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw'
> > [-Werror=unused-variable]
> >  1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
> >       |             ^~~~~~
> > 
> > So perhaps you could consider sending another patch to remove them too.
> > 
> 
> These errors are introduced by this patch, so please fix them together by this
> patch.

Yes, indeed. Sorry for missing that important point.
Had I noticed it my advice would have been the same as yours.