MIME-Version: 1.0
References: <20230301095402.28582-1-hdegoede@redhat.com>
In-Reply-To: <20230301095402.28582-1-hdegoede@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 1 Mar 2023 12:48:09 +0200
Message-ID: <CAHp75VeEnJ5fnme6QTjxN6XjNg82PB5SFMWAHkZBfKTc07tGkQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] mfd: intel_soc_pmic_chtwc: Add Lenovo Yoga Book X90F
 to intel_cht_wc_models
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Andy Shevchenko <andy@kernel.org>, Lee Jones <lee@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 1, 2023 at 11:54=E2=80=AFAM Hans de Goede <hdegoede@redhat.com>=
 wrote:
>
> The Android Lenovo Yoga Book X90F / X90L uses the same charger / fuelgaug=
e
> setup as the already supported Windows Lenovo Yoga Book X91F/L, add
> a DMI match for this to intel_cht_wc_models with driver_data
> set to INTEL_CHT_WC_LENOVO_YOGABOOK1.
>
> When the quirk for the X91F/L was initially added it was written to
> also apply to the X90F/L but this does not work because the Android
> version of the Yoga Book uses completely different DMI strings.
> Also adjust the X91F/L quirk to reflect that it only applies to
> the X91F/L models.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

(Please, update the subject in the next version)

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/mfd/intel_soc_pmic_chtwc.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_p=
mic_chtwc.c
> index d53dae255490..871776d511e3 100644
> --- a/drivers/mfd/intel_soc_pmic_chtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_chtwc.c
> @@ -159,11 +159,19 @@ static const struct dmi_system_id cht_wc_model_dmi_=
ids[] =3D {
>                         DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"),
>                 },
>         }, {
> -               /* Lenovo Yoga Book X90F / X91F / X91L */
> +               /* Lenovo Yoga Book X90F / X90L */
>                 .driver_data =3D (void *)(long)INTEL_CHT_WC_LENOVO_YOGABO=
OK1,
>                 .matches =3D {
> -                       /* Non exact match to match all versions */
> -                       DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> +                       DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporatio=
n"),
> +                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 =
PLATFORM"),
> +                       DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"),
> +               },
> +       }, {
> +               /* Lenovo Yoga Book X91F / X91L */
> +               .driver_data =3D (void *)(long)INTEL_CHT_WC_LENOVO_YOGABO=
OK1,
> +               .matches =3D {
> +                       /* Non exact match to match F + L versions */
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X91"),
>                 },
>         }, {
>                 /* Lenovo Yoga Tab 3 Pro YT3-X90F */
> --
> 2.39.1
>


--=20
With Best Regards,
Andy Shevchenko