Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBC9C64ED6 for ; Wed, 1 Mar 2023 11:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjCALLL (ORCPT ); Wed, 1 Mar 2023 06:11:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjCALLJ (ORCPT ); Wed, 1 Mar 2023 06:11:09 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79D73311F2 for ; Wed, 1 Mar 2023 03:11:00 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4C29E66020E6; Wed, 1 Mar 2023 11:10:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677669057; bh=4v4GBWA4PA/XVvMsfs2bisSUcSFmfwSDKbb1tUfLCw8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CFi+J3Ny2k8aOsMdFamx53fnd+38XmZ4i38wb42qoBWltE515E1u/HmWWoSUR5/LR AV0XI9VZuhLKrZoOo+pPZeX/9gBZQwC5QeM0OcOzh3npjBHYvrWWe5Ii+WDayYVvNg lb4zZT0GlB6YjVEFlZ8W5H8ywnh7cpl6CCadK3ZrDfq+XkMgn+tevzwEpWOg2Ifrnv osABDshFWDg7bo5vasvt0ighqc+hwcFFePegOwRPPymnPGrapuyNKB7KMZGsIHgH+o fDLPlZuSsvCIKlQoaidqOs/CSQequ8dxSf3mfE6C1QbaTmLrj0so4dLPTx4PVlZmuF 2OVzKZx3P0LDQ== Message-ID: Date: Wed, 1 Mar 2023 12:10:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/2] ASoC: mediatek: mt8195: add missing initialization Content-Language: en-US To: Trevor Wu , broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz, matthias.bgg@gmail.com Cc: alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230301110200.26177-1-trevor.wu@mediatek.com> <20230301110200.26177-3-trevor.wu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230301110200.26177-3-trevor.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 01/03/23 12:02, Trevor Wu ha scritto: > In etdm dai driver, dai_etdm_parse_of() function is used to parse dts > properties to get parameters. There are two for-loops which are > sepearately for all etdm and etdm input only cases. In etdm in only > loop, dai_id is not initialized, so it keeps the value intiliazed in > another loop. > > In the patch, add the missing initialization to fix the unexpected > parsing problem. > > Fixes: 1de9a54acafb ("ASoC: mediatek: mt8195: support etdm in platform driver") > Signed-off-by: Trevor Wu Reviewed-by: AngeloGioacchino Del Regno