Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764929AbXILH5s (ORCPT ); Wed, 12 Sep 2007 03:57:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754289AbXILH5k (ORCPT ); Wed, 12 Sep 2007 03:57:40 -0400 Received: from ozlabs.org ([203.10.76.45]:43193 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754077AbXILH5k (ORCPT ); Wed, 12 Sep 2007 03:57:40 -0400 Subject: Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE() From: Michael Ellerman Reply-To: michael@ellerman.id.au To: linuxppc-dev@ozlabs.org Cc: Jeremy Kerr , linux-kernel@vger.kernel.org In-Reply-To: References: <2900ea4dbfd6e98e71ff400cbd25d1283a278972.1189583010.git.michael@ellerman.id.au> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-IjPtDUXEgszoLTPl93oB" Date: Wed, 12 Sep 2007 17:49:13 +1000 Message-Id: <1189583353.17835.22.camel@concordia.ozlabs.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 59 --=-IjPtDUXEgszoLTPl93oB Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: > This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around > DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get > routine for us. >=20 > Unfortunately we need two get routines (a locked and unlocked version) to > support the coredump code. This patch hides one of those (the locked vers= ion) > inside the macro foo. >=20 > Signed-off-by: Michael Ellerman > --- > arch/powerpc/platforms/cell/spufs/file.c | 216 +++++++++++-------------= ------ > 1 files changed, 76 insertions(+), 140 deletions(-) jk said: > "Good god man!" Yeah, I'm a bit lukewarm on this one. But the diffstat is nice, 50% code reduction ain't bad :) cheers --=20 Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-IjPtDUXEgszoLTPl93oB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBG55n5dSjSd0sB4dIRAi9cAJ9bigA9vyHO4Kvx8pjL08siTbt7rgCfX464 B7Crsxl1N1UdibUEPQJNCY4= =HPfv -----END PGP SIGNATURE----- --=-IjPtDUXEgszoLTPl93oB-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/