From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     Ziyang Huang <hzyitc@outlook.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "fabrice.gasnier@foss.st.com" <fabrice.gasnier@foss.st.com>,
        "amelie.delaunay@foss.st.com" <amelie.delaunay@foss.st.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb: dwc2: drd: fix inconsistent mode if
 role-switch-default-mode="host"
Thread-Topic: [PATCH v2] usb: dwc2: drd: fix inconsistent mode if
 role-switch-default-mode="host"
Thread-Index: AQHZRd+knSYE4gin9E6iCq3Lba7rya7l1ssQ
Date:   Wed, 1 Mar 2023 11:34:19 +0000
Message-ID: <BYAPR12MB339967000494531F9B700611A7AD9@BYAPR12MB3399.namprd12.prod.outlook.com>
References: <SG2PR01MB204837BF68EDB0E343D2A375C9A59@SG2PR01MB2048.apcprd01.prod.exchangelabs.com>
In-Reply-To: <SG2PR01MB204837BF68EDB0E343D2A375C9A59@SG2PR01MB2048.apcprd01.prod.exchangelabs.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UJYk59pGa1ymg16vNqmXtT3vT0QFuZCfCJx4nUooxt98M3po5UElVhmK5lEM?=
 =?us-ascii?Q?Xq1voW2k2X9Q8y1Xx+uDBRycokczg1t03zriGYdJclFfRv79xcFq/ZPBDXi1?=
 =?us-ascii?Q?0k97IQsWvETmle8z63NvkzOD9zgtaOS7XVXaSJH0xLmMiZj4xITdlY5cYIdt?=
 =?us-ascii?Q?uID9snXaZD60/OmO0HldVypLfceqeCjOU2L8PNSESA1rPLfm4Uu4hPDJ4Grx?=
 =?us-ascii?Q?9tJGg+n1nPVFNUCgrpln4KMJvJtdu4ocf7OAatl+exAtzSdHpdxmt5hF6sdd?=
 =?us-ascii?Q?MprkzmbbS9WQEevfieGbOGHSLfX8wlevd/C4hrHvmysvSzaXx2p44WaHm9sy?=
 =?us-ascii?Q?dl6X0llgUgvTuLAjF3WaGMMZcJ9LmggGKTCb4OhX/efeQ7UP6Pzp26bUgBDp?=
 =?us-ascii?Q?sj+miqfB9e3vz+NW4STuo57TmiQ+9a3GcOb959RiYcM3XwyYfV8vt4gLdtft?=
 =?us-ascii?Q?27IFg5KxGlIXFefs0ZYFhYykdddvzl/t1HcIJUOVO5cawVPu9TGY64QkrcJ4?=
 =?us-ascii?Q?2ezrg1LzlRb5NuxwqEgGGQoW3DCWe34HTGjOLqq6d1RGZnVqPBzQdDND9EEz?=
 =?us-ascii?Q?m5wqYHzTfhNyC5K/VI6alFyAFZ/mU6Pz5Rai4rR1+srxde8k/H9OwVhc8kvX?=
 =?us-ascii?Q?LlSs6OrSHGJ5X5sYxHa4Ih7lG6qoHi0CK6osP0JBcJ6Zepy+Vqcp3lzd5XDr?=
 =?us-ascii?Q?VbbtVwkiLJsWTfSrsJ/0s1wW/K3DfQBstM8T9FLt/+Plg7oTW4s//AYeOVLr?=
 =?us-ascii?Q?cYsAdlKbdfFE/SsonfEDfZoFAq8ClPQtZYd6uPYc4/9QbBBwer1CPss2Vyyd?=
 =?us-ascii?Q?1DyBT1hZJXrXhYxmGDIEblbRrID5X3ZgnZqqa9T72FYac5LG3mgAMCGamABq?=
 =?us-ascii?Q?UFPQa+OuATlPqdtEJXgP4kAJ62ujG+tJWmnyyoMAKvF76j360uPvRy9GOVU8?=
 =?us-ascii?Q?KIi+m+8f+Zo56tCmWQefPXxZPb/go+nJ/S1McmKbI3JV5HtwDYQpBVmhuNLx?=
 =?us-ascii?Q?L4dVXKxXhp8JDxlnURDoueluvA+7ersnS5srutq74hDc22KxSvrSdmG/aOTa?=
 =?us-ascii?Q?c2PZL96afVbpAlRcii4MmnWMDcZIplmlhyEq47sICSDTJpivZNOnGDVU1iX8?=
 =?us-ascii?Q?uSCMoDQ7o2AJEOjI+J52U4y/8EWw9N2Ma5dPlEG5nmZO/HKkl0p9jGdxqll0?=
 =?us-ascii?Q?6dHjcEymILcNqETjqwoM/TZsFAHnrL1Y4w5FE3MvkPaWC8ZeuEjtIoa+5Whu?=
 =?us-ascii?Q?YyrpvLorhjJk2f/4B12I415OhNf6qwwa2bsic696cKfZy96spHGacBYZ+uRm?=
 =?us-ascii?Q?yPvWH59Nvnk0d3FgN6k6m5udwnvaEEXRdSFuG6sgkQ7h+yDCxDN3vp9VS3de?=
 =?us-ascii?Q?v5OT53CnRxhGUjAIyR11ZzuQkc8Fi3p8YVCOaINvbWbCFjH0hhLv75cWHPKJ?=
 =?us-ascii?Q?oAbBdS7pRWfTswBZ22IVPIpomFs/9Uh9F7X2Q6CfgnvjOLAUJrWrLbIpR15v?=
 =?us-ascii?Q?P5JJ9cyKrtwpiloAUErXIBRcKJ/A2W7Y6T2Kt2wyxPIS5Dwpm9ASSnztJR0b?=
 =?us-ascii?Q?eY+51NdNR8Z4axvygM0DGxpl/29J9eQUtteyAGW8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1uLdDmNAh8YTTI3T8vOVx6kzgMLmEXOmnL3U1b+ILdGJhav/TiYJ1uewIHzF/0BCeKvLgt8dGIJqhauOu1MgSLLtXj6+Pl9sYCvrfbchRe4ziZ8WOadE2+C79gLZvDg3AQ3H36ili8hFmakqEbRaoHX3Q6wmh8uUMN3Z2lwqcc5qLyKpDgWyb6K6wDGZTf1llsugHLiQ3Syg9fDEdkZueFNVs2rYt9lKRuVmhVq/TnFbtr08J98r/ETunt+EVQWHB2QtZOABRM9ZH94EeeE7Jqxj59aWgEHUMZnTE+LGiqvSWUYvAONPYVfquLrujQeohf7j0inNVEaXjU3Mjgkp2H8Lqrs0bkU3owEWUa4JcJ8pJ2T06f8F1PXLflLPUeIEgd1mjHGEqrtOT8fdAQqR/t/hAOU8Vb18e6zbIFfpANCP4HlNvC9oDL8X82hHobXjt9UK1XcXRszaQjtBYxono1F+I35g9V5nyXTacpWq+kl21lv3MeENk4KY6IpC/KPDHWimuuDUfRVQbT9VCnLpZLsj00Icaom1iKwxkJUCWo0sIl3b0cJnWkBSlku3k//K7Fdm1mDtpthgtqOmVXG0ESXIPaqvbMwfOkH/sCqfNJPxvHDu+/3z5dF42mp/2Y5oUVx3CaZrEgTWSoabq4+dbmbog0egxyWcRbSuoC6EeHpKu/NT12iiLAk/KNhEnQq8I3LdplY71POC9PMJXnq9OjvOPB9dxe7bRu/4v73iL/Qxt7Pf7TEYO43Ts0NY0ouXBy0029zcsmnlbNtM+69oMZASQtTc8sGujR4Bq+nXB1tTt9sU+AGXghPA0wlRxGJoxnIV1o761QrNcvmZFN0bx4M+cR2/lox3Lckb10YqwOWfGd2JJ78jrxfUGVPAENIQ9JSKb7WpYlhXtxktBicBVWHLO+ReTaH7B013iJXaZ2s=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3399.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a42d894b-dc12-424a-31c1-08db1a48e56e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2023 11:34:19.1603
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: csIX/Ar+q75M4PuTlWfm8kmshmyQkdWj+PX3hE41Qclc98g520w2lH+i0hCIk5JkwQsZBBDlEiq1qVSw+3msYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6009
X-Proofpoint-GUID: o0b8xyfzlVUE2vPDlJM5fvluMBON8vSo
X-Proofpoint-ORIG-GUID: o0b8xyfzlVUE2vPDlJM5fvluMBON8vSo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-01_07,2023-03-01_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 mlxlogscore=999 adultscore=0 clxscore=1015 lowpriorityscore=0
 malwarescore=0 impostorscore=0 mlxscore=0 phishscore=0 spamscore=0
 suspectscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303010095
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ziyang,

On 2/21/2023 2:30 PM, Ziyang Huang <hzyitc@outlook.com> wrote:
>From: Ziyang Huang <hzyitc@outlook.com>
>Sent: Tuesday, February 21, 2023 2:30 PM
>To: Minas Harutyunyan <hminas@synopsys.com>
>Cc: gregkh@linuxfoundation.org; fabrice.gasnier@foss.st.com;
>amelie.delaunay@foss.st.com; linux-usb@vger.kernel.org; linux-
>kernel@vger.kernel.org; Ziyang Huang <hzyitc@outlook.com>
>Subject: [PATCH v2] usb: dwc2: drd: fix inconsistent mode if role-switch-
>default-mode=3D"host"
>
>Some boards might use USB-A female connector for USB ports, however, the
>port could be connected to a dual-mode USB controller, making it also
>behaves as a peripheral device if male-to-male cable is connected.
>
>In this case, the dts looks like this:
>
>	&usb0 {
>		status =3D "okay";
>		dr_mode =3D "otg";
>		usb-role-switch;
>		role-switch-default-mode =3D "host";
>	};
>
>After boot, dwc2_ovr_init() sets GOTGCTL to GOTGCTL_AVALOVAL and call
>dwc2_force_mode() with parameter host=3Dfalse, which causes inconsistent m=
ode
>- The hardware is in peripheral mode while the kernel status is in host
>mode.
>
>What we can do now is to call dwc2_drd_role_sw_set() to switch to device
>mode, and everything should work just fine now, even switching back to
>none(default) mode afterwards.
>
>Fixes: e14acb876985 ("usb: dwc2: drd: add role-switch-default-node support=
")
>Signed-off-by: Ziyang Huang <hzyitc@outlook.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Tested-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>


Thanks,
Minas


>---
>Changes since v1
>- Use corrent name in Signed-off-by
>
> drivers/usb/dwc2/drd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/usb/dwc2/drd.c b/drivers/usb/dwc2/drd.c index
>d8d6493bc457..a8605b02115b 100644
>--- a/drivers/usb/dwc2/drd.c
>+++ b/drivers/usb/dwc2/drd.c
>@@ -35,7 +35,8 @@ static void dwc2_ovr_init(struct dwc2_hsotg *hsotg)
>
> 	spin_unlock_irqrestore(&hsotg->lock, flags);
>
>-	dwc2_force_mode(hsotg, (hsotg->dr_mode =3D=3D USB_DR_MODE_HOST));
>+	dwc2_force_mode(hsotg, (hsotg->dr_mode =3D=3D USB_DR_MODE_HOST) ||
>+				(hsotg->role_sw_default_mode =3D=3D USB_DR_MODE_HOST));
> }
>
> static int dwc2_ovr_avalid(struct dwc2_hsotg *hsotg, bool valid)
>--
>2.34.1