From:   "J.D. Yue" <jindong.yue@nxp.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        Peng Fan <peng.fan@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: RE: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
 dev_pm_domain_attach_by_name
Thread-Topic: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
 dev_pm_domain_attach_by_name
Thread-Index: AQHZTDnHyebNUArZAUOYHrMHVoGHdw==
Date:   Wed, 1 Mar 2023 12:31:42 +0000
Message-ID: <GV1PR04MB91834769F5276CED6D0F9623FBAD9@GV1PR04MB9183.eurprd04.prod.outlook.com>
References: <20230301030042.2357706-1-jindong.yue@nxp.com>
 <20230301030042.2357706-2-jindong.yue@nxp.com>
 <20230301093102.f76wulx4mo7435qz@pengutronix.de>
In-Reply-To: <20230301093102.f76wulx4mo7435qz@pengutronix.de>
Accept-Language: en-US, zh-CN
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+xcbB28MLFAxsgo9nd9FhxqpI8C9iYSzkksZjMkZWLedu0NsfdjQIYQJfUkp?=
 =?us-ascii?Q?FFaKg/i5/vWdkeTXTL5iSHo7U4Q+Omv2BwUNp0zamaGOOrMemm5JeCXx25zq?=
 =?us-ascii?Q?CwxeV8hhbxBa6oKG4FB7erRNKH36LwoJ6nLSGnFi/YdAux0v2W94ABMKSr0t?=
 =?us-ascii?Q?eQ9DgpSwGPFPaIS2VV91gUA+8n7vN4cwB4kL3SITurkHyJLIGAlXz+frwag6?=
 =?us-ascii?Q?V0mAN/oZ0sdWcPJIq9mXFhJ8Jvc+qqr23rLZpBSk7tCCQ11N6Q+7xVcMdKt2?=
 =?us-ascii?Q?fqZ9zeJJYDYNkIYHpFctsO5e9aA8ud1ukpklcxmGiy4lNSSYeMNCvYex4evc?=
 =?us-ascii?Q?7AR5keP8O36/oiM5Yxkqc/KRJuQNKX9tDjFjMqenX2c2fFs+NqWUUyXb9Fey?=
 =?us-ascii?Q?DkXZS/sMgftytOtfBTESEVJ9ythDpAC8fZE1qu/q9hWbVeO6GaeY0bcc8NAj?=
 =?us-ascii?Q?Yzz1R8mv3BcWg4XRuP/vyJ2hdeihFfqlA9akcW4hJ+sIZ9PqDUfZOwiQdQ1P?=
 =?us-ascii?Q?1QEVvAAYl8y7HDf6Bz42kpfntMcxAgsQ/h7SUCpkfUtV0vegvgRMhk/RjkZF?=
 =?us-ascii?Q?FK7hHgIC3yQjpZL/5EnyEjwF1jKJ7haroFtBG+MKATh6VxMX7xMwmwrukkYn?=
 =?us-ascii?Q?Zrf83itvx8zi0biDAyRNfHu/MLco4mdfa6Mw4Fa7Ky5eTmY+xaPYD387/zxE?=
 =?us-ascii?Q?fA88JTJwh3BR/nXGm8XB25WKxCV4vtfbUj9CwWJHT0qZuS0hhk6gmF5vjOjX?=
 =?us-ascii?Q?Ez2TdbiOhi6xm0P3TqOzSLKSSgpTM3KJcy9hWzB1b4xoac0Uh1t5ztNlMFqR?=
 =?us-ascii?Q?p501CQbQ/eUlM8FOW6XeqwdcYwdEhK2Nvceb7xijGlHcVhOrKF/QaUvv+Cu8?=
 =?us-ascii?Q?6B0S44EB00sgJXZn3Z2e+64pCCwwxHv9aObeFVDDbWl5aywU6o6wP3slR3A/?=
 =?us-ascii?Q?Z3WCQG1eJFsmAb1aXfWzaQMBFHLtg8Vb4RwaIe0fxMvp4RlMPmSO3KYsqIZX?=
 =?us-ascii?Q?1Ebw46tOyhMmPxN82bRj08WKC40dE3lv/SXenTeEmvxwIH6x6LVXqQnKrfmO?=
 =?us-ascii?Q?iKqonaCbjDzOFNGb0wXx/4hrX8kLHVokkWjkFQ8uRl7P347/TwYhvtu4Ne8q?=
 =?us-ascii?Q?jWvA/Sstrp7mUXBr3VoAtgzo4fd3PYgeplJVIAiBW+chC1NeqHnKTORMpjQR?=
 =?us-ascii?Q?WYulNR/5Ul84cck6CM628HNjZfPIKxPuj4A/LbqdfSVjpWrtHSWpHhzlQ9W9?=
 =?us-ascii?Q?iLlyVGdMprKArqoTWJpwBz+dfbvrSxIOJ7o+jcuAiNJWOebpl1JL25YGC6v6?=
 =?us-ascii?Q?IdXVXxn+QRyOQ0A89Sp6L//NkbLu8lmH/WR/Ni2b8/pp06/2FM7UOCfHWraj?=
 =?us-ascii?Q?t9WpE0CPjGrGL9l8oPCNjPR0bcgH4oguTiMvyHjmwvFXsH6uHkyST7T7tdA+?=
 =?us-ascii?Q?TMw7snyAOEwd76mrG0s6QnKOo3mms7T6PPvRAnn+pN6vp0pLek0yx9YgQ6nG?=
 =?us-ascii?Q?bQDix+RlkQ3C6emmOkaDiC/BT0NjN0EvyDSkfgEd0oyNwcXu2JYkc/sXSnp/?=
 =?us-ascii?Q?D/q2O+FzzKiYbsBk2M4/qG+VuiYuQ5tpp4VgDQM/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9183.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd43c7dd-8a88-44b1-2101-08db1a50e9f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2023 12:31:42.7500
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 92ePRgy/GZkOOC6xPsQ9oCTkhGrjfOcqy2MZgNKwPaxE0JvcUY6oE+FnNpVgNS4swkN4dgqX0YCNOkJAgx7QDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8233
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Marco Felsch <m.felsch@pengutronix.de>
> Sent: Wednesday, March 1, 2023 5:31 PM
> To: J.D. Yue <jindong.yue@nxp.com>
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; Peng Fan
> <peng.fan@nxp.com>; gregkh@linuxfoundation.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> kernel@pengutronix.de; festevam@gmail.com; l.stach@pengutronix.de
> Subject: [EXT] Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
> dev_pm_domain_attach_by_name
>=20
>=20
> Hi,
>=20
> thanks for the patch.
>=20
> On 23-03-01, Jindong Yue wrote:
> > The genpd_dev_pm_attach_by_name() is not exported, it should not be
> > used by consumer driver.
> > Use dev_pm_domain_attach_by_name() instead.
>=20
> I'm not sure if this is the correct reason. If it wouldn't be allowed to =
be used by
> consumers it would/should be private. Instead you should mention here tha=
t
> you need the symbol for possible module builds. Same applies to the other
> patches.
>=20

You are correct, I ran into symbol undefined errors when building this driv=
er as a module.
I will update the commit message in v3 as you suggested. Thank you very muc=
h.

> Regards,
>   Marco
>=20
> >
> > Signed-off-by: Jindong Yue <jindong.yue@nxp.com>
> > ---
> >  drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c
> > b/drivers/soc/imx/imx8mp-blk-ctrl.c
> > index a0592db8fa86..1892c2c78831 100644
> > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c
> > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
> > @@ -642,7 +642,7 @@ static int imx8mp_blk_ctrl_probe(struct
> platform_device *pdev)
> >       if (!bc->onecell_data.domains)
> >               return -ENOMEM;
> >
> > -     bc->bus_power_dev =3D genpd_dev_pm_attach_by_name(dev, "bus");
> > +     bc->bus_power_dev =3D dev_pm_domain_attach_by_name(dev, "bus");
> >       if (IS_ERR(bc->bus_power_dev))
> >               return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> >                                    "failed to attach bus power
> > domain\n");
> > --
> > 2.36.0
> >
> >
> >