From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Jan Kara <jack@suse.cz>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git sysv pile
Date:   Wed, 01 Mar 2023 14:21:56 +0100
Message-ID: <8187743.T7Z3S40VBb@suse>
In-Reply-To: <20230301130018.yqds5yvqj7q26f7e@quack3>
References: <Y/gugbqq858QXJBY@ZenIV> <13214812.uLZWGnKmhe@suse>
 <20230301130018.yqds5yvqj7q26f7e@quack3>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On mercoled=EC 1 marzo 2023 14:00:18 CET Jan Kara wrote:
> On Wed 01-03-23 12:20:56, Fabio M. De Francesco wrote:
> > On venerd=EC 24 febbraio 2023 04:26:57 CET Al Viro wrote:
> > > 	Fabio's "switch to kmap_local_page()" patchset (originally after the
> > >=20
> > > ext2 counterpart, with a lot of cleaning up done to it; as the matter=
 of
> > > fact, ext2 side is in need of similar cleanups - calling conventions=
=20
there
> > > are bloody awful).
> >=20
> > If nobody else is already working on these cleanups in ext2 following y=
our
> > suggestion, I'd be happy to work on this by the end of this week. I only
> > need
> > a confirmation because I'd hate to duplicate someone else work.
> >=20
> > > Plus the equivalents of minix stuff...
> >=20
> > I don't know this other filesystem but I could take a look and see whet=
her
> > it
> > resembles somehow sysv and ext2 (if so, this work would be pretty simple
> > too,
> > thanks to your kind suggestions when I worked on sysv and ufs).
> >=20
> > I'm adding Jan to the Cc list to hear whether he is aware of anybody el=
se
> > working on this changes for ext2. I'm waiting for a reply from you (@Al=
)=20
or
> > Jan to avoid duplication (as said above).
>=20
> I'm not sure what exactly Al doesn't like about how ext2 handles pages and
> mapping but if you have some cleanups in mind, sure go ahead.

Hi Jan,

I might explain here and now what Al is referring to I'd prefer to show the=
=20
code :-)

In brief I had made the conversions of fs/ufs and fs/sysv from kmap() to=20
kmap_local_page() by porting what had been done for ext2. At that point Al=
=20
suggested a much cleaner and elegant approach.=20

Therefore, I threw away the port from ext2 and sent a series of 4 patches=20
according to a long list of suggestions that Al kindly provided to me.

Now he is asking for somebody doing the same changes in ext2 too.

Thanks for the immediate reply.

=46abio  =20

> I don't have
> any plans on working on that code in the near term.
>=20
> 							=09
Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR