Message-ID: <b82fa9d1-fcd6-b214-f0f3-532e7f7d8a00@redhat.com>
Date:   Wed, 1 Mar 2023 15:25:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 02/12] platform/x86: ISST: Add TPMI target
Content-Language: en-US, nl
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230211063257.311746-1-srinivas.pandruvada@linux.intel.com>
 <20230211063257.311746-3-srinivas.pandruvada@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230211063257.311746-3-srinivas.pandruvada@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2/11/23 07:32, Srinivas Pandruvada wrote:
> Add TPMI as one of the device type which can be registered with ISST
> common driver.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Thank I've applied this patches 2-4 to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

These patches are intended for the next rc1. This branch will get
rebased to the next rc1 when it is out and after the rebasing the
contents of review-hans will be pushed to
the platform-drivers-x86/for-next branch.

Please base the next version of this series (minus patches 1-4)
on pdx86/review-hans or if patches 1-4 have landed there on
platform-drivers-x86/for-next .

Regards,

Hans


> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> index 35ff506b402e..967c338e83c5 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> @@ -30,7 +30,8 @@
>  
>  #define ISST_IF_DEV_MBOX	0
>  #define ISST_IF_DEV_MMIO	1
> -#define ISST_IF_DEV_MAX		2
> +#define ISST_IF_DEV_TPMI	2
> +#define ISST_IF_DEV_MAX		3
>  
>  /**
>   * struct isst_if_cmd_cb - Used to register a IOCTL handler