Date:   Wed, 1 Mar 2023 15:29:56 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Niklas =?utf-8?Q?S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4 17/19] thermal/tegra: Do not enable the thermal zone,
 it is already enabled
Message-ID: <Y/9hZFfRWLNHMbxe@orome>
References: <20230228112238.2312273-1-daniel.lezcano@linaro.org>
 <20230228112238.2312273-18-daniel.lezcano@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2/FgaCS/nnqqQf+a"
Content-Disposition: inline
In-Reply-To: <20230228112238.2312273-18-daniel.lezcano@linaro.org>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--2/FgaCS/nnqqQf+a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 28, 2023 at 12:22:36PM +0100, Daniel Lezcano wrote:
> The code enables the thermal zone after setting it up. But the thermal
> zone is already enabled by thermal_of_zone_register() function.
>=20
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/thermal/tegra/tegra30-tsensor.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>=20
> diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/te=
gra/tegra30-tsensor.c
> index 3506c3f3c474..e38902abf207 100644
> --- a/drivers/thermal/tegra/tegra30-tsensor.c
> +++ b/drivers/thermal/tegra/tegra30-tsensor.c
> @@ -346,7 +346,7 @@ static int tegra_tsensor_enable_hw_channel(const stru=
ct tegra_tsensor *ts,
>  {
>  	const struct tegra_tsensor_channel *tsc =3D &ts->ch[id];
>  	struct thermal_zone_device *tzd =3D tsc->tzd;
> -	int err, hot_trip =3D 0, crit_trip =3D 0;
> +	int hot_trip =3D 0, crit_trip =3D 0;
>  	u32 val;
> =20
>  	if (!tzd) {
> @@ -401,12 +401,6 @@ static int tegra_tsensor_enable_hw_channel(const str=
uct tegra_tsensor *ts,
>  	val |=3D FIELD_PREP(TSENSOR_SENSOR0_CONFIG0_INTR_THERMAL_RST_EN, 1);
>  	writel_relaxed(val, tsc->regs + TSENSOR_SENSOR0_CONFIG0);
> =20
> -	err =3D thermal_zone_device_enable(tzd);
> -	if (err) {
> -		dev_err(ts->dev, "ch%u: failed to enable zone: %d\n", id, err);
> -		return err;
> -	}
> -
>  	return 0;
>  }

This function is called in tegra_tsensor_resume() and balances out the
tegra_tsensor_hw_channel() calls from tegra_tsensor_suspend(). If we
remove the call from here, we'll likely end up with the zones disabled
after a resume.

This ends up calling thermal_zone_device_set_mode(), which is a no-op,
basically, if the mode is unchanged, so this seems harmless.

If you need this to change anyway, I suppose we could move the calls to
thermal_zone_device_enable() and move them into suspend/resume instead.
That's a bit tricky to undo in the error recovery paths, but should be
doable.

Thierry

--2/FgaCS/nnqqQf+a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmP/YWIACgkQ3SOs138+
s6EjvQ//TG4Y9PWRAFjYc4KItj+lcgjVK3rv1bnPSkolJ7aAHkSc9mnkrz8NP+le
adXN4EJ0xdcouPOslRQdaGFnAhr8+e8TK1LtJa/ReUuY4ZAP7PQzK+b4Y4SYlegd
GK7Ei9Oe6OFS3vhoK96DuZJyiBAZA2dDTUSaW+N6tlMl4wBrbIxupb2FI7X1w+Vu
vXFbIoqSGi7pR7vsYerMjGA9nuGe36Kgq2dmGs5pax6C/oYMo1s5+hcllxFsIjb4
+FbGrnNNBXYqN/erAnAmPm5LzqxBOgf1RJEOyXf1xuFo+HdEaIretcq6pF3PiPiy
SAcE6RRaA6dCZVkgNxd6qVgDohdrulcP4JqY7cIECnWFY6X1z1AChT6X6UJ0dHah
VcoJvzEHFTQ3UuqXttflNh/lMHxwGkiEi86Tk5NtfjerJMwwcmUVWfkQUZTC+UhS
dABwWSKc0c+aKgt4O6y9YbqjU9dZ9y7ko9kgr+Yv5SM8oLGdavAT+0+3jmfWvPTT
BY+L589PebEwpexP31d6LUDxr9Ifha/gvu4MXbIh93eCLt2DX73hlVuRiof4DFt3
V2atdEQ4ygf2GKGIfvLCOWmak4S3T4sXBpX0Bp+1Y3Dza7mulJaBj/GxJx6rYxBF
xdLPxBwbxiO+egs3nKioP+4LgrsGB6m+MXFvwe2swwbWMjklfSc=
=Ggnj
-----END PGP SIGNATURE-----

--2/FgaCS/nnqqQf+a--