Message-ID: <bc3ad416cf45aa1e8fe1f466a09a9388b0aaf7ab.camel@linux.intel.com>
Subject: Re: [PATCH 01/12] platform/x86: ISST: Fix kernel documentation
 warnings
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 01 Mar 2023 06:48:02 -0800
In-Reply-To: <39b98cb1-1ef5-dabf-5f01-2f673b2b59b1@redhat.com>
References: <20230211063257.311746-1-srinivas.pandruvada@linux.intel.com>
         <20230211063257.311746-2-srinivas.pandruvada@linux.intel.com>
         <39b98cb1-1ef5-dabf-5f01-2f673b2b59b1@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Hans,

Since some patches you are adding to your review branch,
shall I exclude those from new series by rebasing on=C2=A0
your review-hans branch?
?

Thanks,
Srinivas

On Wed, 2023-03-01 at 15:23 +0100, Hans de Goede wrote:
> Hi,
>=20
> On 2/11/23 07:32, Srinivas Pandruvada wrote:
> > Fix warning displayed for "make W=3D1" for kernel documentation.
> >=20
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@linux.intel.com>
>=20
> Thanks, I've applied this patch to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x8=
6.git/log/?h=3Dreview-hans
>=20
> I'll rebase that branch once 6.3-rc1 is out and then push the rebased
> patch to the fixes branch and include it in my next 6.3 fixes pull-
> req
> to Linus.
>=20
> Regards,
>=20
> Hans
>=20
>=20
>=20
>=20
>=20
> > ---
> > =C2=A0drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3
> > ++-
> > =C2=A0drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 1 +
> > =C2=A02 files changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git
> > a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> > b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> > index a7e02b24a87a..63d49fe17a16 100644
> > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> > @@ -112,6 +112,7 @@ static void isst_delete_hash(void)
> > =C2=A0 * isst_store_cmd() - Store command to a hash table
> > =C2=A0 * @cmd: Mailbox command.
> > =C2=A0 * @sub_cmd: Mailbox sub-command or MSR id.
> > + * @cpu: Target CPU for the command
> > =C2=A0 * @mbox_cmd_type: Mailbox or MSR command.
> > =C2=A0 * @param: Mailbox parameter.
> > =C2=A0 * @data: Mailbox request data or MSR data.
> > @@ -363,7 +364,7 @@ static struct pci_dev *_isst_if_get_pci_dev(int
> > cpu, int bus_no, int dev, int fn
> > =C2=A0/**
> > =C2=A0 * isst_if_get_pci_dev() - Get the PCI device instance for a CPU
> > =C2=A0 * @cpu: Logical CPU number.
> > - * @bus_number: The bus number assigned by the hardware.
> > + * @bus_no: The bus number assigned by the hardware.
> > =C2=A0 * @dev: The device number assigned by the hardware.
> > =C2=A0 * @fn: The function number assigned by the hardware.
> > =C2=A0 *
> > diff --git
> > a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> > b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> > index fdecdae248d7..35ff506b402e 100644
> > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h
> > @@ -40,6 +40,7 @@
> > =C2=A0 * @offset:=C2=A0=C2=A0=C2=A0=C2=A0Offset to the first valid memb=
er in command
> > structure.
> > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0This will be the offset of the start of the command
> > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0after command count field
> > + * @owner:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Registered module owner
> > =C2=A0 * @cmd_callback: Callback function to handle IOCTL. The callback
> > has the
> > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0command pointer with data for command. There is a
> > pointer
> > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0called write_only, which when set, will not copy
> > the
>=20