Date:   Wed, 1 Mar 2023 14:50:55 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lucas Tanure <lucas.tanure@collabora.com>
Cc:     David Rhodes <david.rhodes@cirrus.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        "Takashi Iwai --cc=alsa-devel @ alsa-project . org" <tiwai@suse.com>,
        patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH v3] ASoC: cs35l41: Steam Deck Shared boost properties
 quirk
Message-ID: <Y/9mT2ZVzf/5o4QV@sirena.org.uk>
References: <20230301124447.17672-1-lucas.tanure@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8Gla6hySb4xhSKuC"
Content-Disposition: inline
In-Reply-To: <20230301124447.17672-1-lucas.tanure@collabora.com>
Precedence: bulk


--8Gla6hySb4xhSKuC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 01, 2023 at 12:44:47PM +0000, Lucas Tanure wrote:
> Add support for Steam Deck bios old properties. If a Steam deck didn't
> upgrade the BIOS, the driver should be able to handle the previous
> properties for shared boost types.

This doesn't build:

/build/stage/linux/sound/soc/codecs/cs35l41.c: In function =E2=80=98cs35l41=
_handle_pdata=E2=80=99:
/build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: error: =E2=80=98CS35=
L41_SHD_BOOST_ACTV=E2=80=99 undeclared (first use in this function); did yo=
u mean =E2=80=98CS35L41_EXT_BOOST=E2=80=99?
 1041 |                 hw_cfg->bst_type =3D CS35L41_SHD_BOOST_ACTV;
      |                                    ^~~~~~~~~~~~~~~~~~~~~~
      |                                    CS35L41_EXT_BOOST
/build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: note: each undeclare=
d identifier is reported only once for each function it appears in
/build/stage/linux/sound/soc/codecs/cs35l41.c:1043:36: error: =E2=80=98CS35=
L41_SHD_BOOST_PASS=E2=80=99 undeclared (first use in this function); did yo=
u mean =E2=80=98CS35L41_EXT_BOOST=E2=80=99?
 1043 |                 hw_cfg->bst_type =3D CS35L41_SHD_BOOST_PASS;
      |                                    ^~~~~~~~~~~~~~~~~~~~~~
      |                                    CS35L41_EXT_BOOST


--8Gla6hySb4xhSKuC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP/Zk4ACgkQJNaLcl1U
h9AS3gf/dFCy7mGxEZ4YMb0SnBBAy/ph/RMHSIZG3QWBIDSufaw3d779cwZ/lRdJ
ZKrWVfg2tdCiq00nIT3p7U8sv1Y1BkdZCS86kleKSx81enGThIodHPVwf46y5YAx
9F2XeoHJLvR8Ku+RPUDsPHAQqsiVzoD/rgSVDI+NnJujb68s+h5CT+u25v1Ccnmk
mO+gMstPIjv2AOkhL4YlrQn/D3GgmlVOdjw8eskyMM+6L9Z1ZYAQA9wCIHW80T8e
kcTfQ9/65CnleuBxUXTzDWH9dpOjshE0rXN3vvyfQfu95ZC/gFzSeSBpfrhPDxqi
2Vp6CN8sTSDX2KjhznCH9jAth4HWkw==
=1Jor
-----END PGP SIGNATURE-----

--8Gla6hySb4xhSKuC--