Date:   Wed, 1 Mar 2023 16:07:47 +0100
From:   Florian Westphal <fw@strlen.de>
To:     Madhu Koriginja <madhu.koriginja@nxp.com>
Cc:     gerrit@erg.abdn.ac.uk, davem@davemloft.net, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, edumazet@google.com, dccp@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        vani.namala@nxp.com
Subject: Re: [PATCH] [NETFILTER]: Keep conntrack reference until IPsecv6
 policy checks are done
Message-ID: <20230301150747.GB4691@breakpoint.cc>
References: <20230301145534.421569-1-madhu.koriginja@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230301145534.421569-1-madhu.koriginja@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Madhu Koriginja <madhu.koriginja@nxp.com> wrote:
> Keep the conntrack reference until policy checks have been performed for
> IPsec V6 NAT support. The reference needs to be dropped before a packet is
> queued to avoid having the conntrack module unloadable.

In the old days there was no ipv6 nat so its not surpising
that ipv6 discards the conntrack entry earlier than ipv4.

> -		if (!(ipprot->flags & INET6_PROTO_NOPOLICY) &&
> -		    !xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb))
> -			goto discard;
> +
> +		if (!ipprot->flags & INET6_PROTO_NOPOLICY) {

This looks wrong, why did you drop the () ?

if (!(ipprot->flags & INET6_PROTO_NOPOLICY)) { ...

rest LGTM.