Date:   Wed, 1 Mar 2023 17:25:27 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Daniel Scally <djrscally@gmail.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Implementation of fwnode_operations :: device_get_match_data()
 for software nodes?
Message-ID: <20230301152527.khyzifds4w3rkebt@skbuf>
References: <20230223203713.hcse3mkbq3m6sogb@skbuf>
 <Y/0uC1LgeWR0V0ts@smile.fi.intel.com>
 <20230227234411.jqmwshzkeyx6iqyo@skbuf>
 <Y/9iLBWAO37y6lZZ@smile.fi.intel.com>
 <20230301143625.7kdnzujlv4psbhla@skbuf>
 <Y/9qtT0vckSikOKJ@smile.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/9qtT0vckSikOKJ@smile.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F+oSmuDe9sVIbJ/6mdl9cRUqSoI5IRxsAN4o842eziJ+ewuP+IhgwHtUoTG1?=
 =?us-ascii?Q?FN94cdM8hFbEuc9dGQTh1Ydg/WOP/ISOFZZIxwqCMt3WJ/4AgdSptCTwJ6QV?=
 =?us-ascii?Q?HPZGdPAZbSuXw7Pmr2pqnFbm7b8ru772shvllU5l0XLk70FHBJa1w3EL9Yzv?=
 =?us-ascii?Q?kYAN86J3ARsaS+nvWCOx3eUFBRfFbdUMvjehMqh9R+3Rc4yXR5LaodKRByvK?=
 =?us-ascii?Q?idyS2nTNl/YjV6bX9Wl1kIrgHeCRU6+OvRW7H4WaPNNlQayfmLJnaHms8xZM?=
 =?us-ascii?Q?7j99XeDe9juCuJjqEN4SG66xSiyukUBK6HNxfFvkQaotrJq4seyCiZs2h79+?=
 =?us-ascii?Q?Fq5eObPvyn/GzptGN2bgTW8Mcj99QFPhYgKbSdkYWnl+7zm2mSTOlhNV5rlh?=
 =?us-ascii?Q?RXvQxM1Apn2BTRpTrYflNNknMRbd2DGM3VZFQ7TAp1+3j8nNJiFU5EWX61PX?=
 =?us-ascii?Q?6nZRZUqeSs8iA3anJBQrvmDY1IVGClIHC1+Ay/W9i5hYdJM963t84y0c1v+r?=
 =?us-ascii?Q?vBZvOPdwTaKOc8atRG7PwIVSRoAcm6x4eCBeBeC2X195Wbq3VPIwzIpnXk6k?=
 =?us-ascii?Q?raRFz7B+e71bC5ydoiipwLBwIA3KYpbG+XW6MFaeVo7yWGn2I0wrgyfrk0Ey?=
 =?us-ascii?Q?62SPEMKLDeH9ItlRM3tsE9jOxUwCCBvxGiLhWK8GaHO9ONvABWSHPAdpqLpt?=
 =?us-ascii?Q?5y3hWUfiKeettky/HAlImq1SggRFOeLxFPU6snvMNOwEHkLnuuLCKmeC+3hQ?=
 =?us-ascii?Q?6n7Bl3e8+JIU2L0GR6ZG4NLEtSWHymQpBGokXzyPA/QELk2wgQUdZfy7g/QL?=
 =?us-ascii?Q?fr0HkyQALjCZKzDMMq0EMecO9ak+2rg2BplA/iyKUwAQGgyw7KWwdubKZtvG?=
 =?us-ascii?Q?fxG17p/nEuRZ2Z+NCIlHeLng9NtALmVcLIS8mNqrDNTbn8DKxyOCHxhBuqnX?=
 =?us-ascii?Q?BJlkbBW9tZ5z+jYU7g4fKi2bre6PykZpy3NBnEa3ozxzvEOc5QH95NnR86f0?=
 =?us-ascii?Q?7Hluk03Yy3NZ3xdvwuCmIsl1OnDDOuEBM8KW1IRrGr+2JM/Tlo2gM14UKadz?=
 =?us-ascii?Q?0icsrnWL8enqvGS9Obfj7wB0sGa8fECqogBzir2TpX4M7Rl1lqlxVforcgCr?=
 =?us-ascii?Q?EhdSSXuVUla3oNLztQcJAr3w1NsH19VVGTVwJEay6sr2QLs6PDB0Y9RzbZMQ?=
 =?us-ascii?Q?G+6GIR77gLExaSggXnP1ZyoQC+TjG5j2C0jj3sZBK0oyD91+RqtkmEQByqhw?=
 =?us-ascii?Q?PUXzQwhSINoq3LPrGKezCrSQ+1PaCdrakAP6szN0pSODUjyKKqinoU2vRIoz?=
 =?us-ascii?Q?cMwwTEcLFWGHnOTNFEXrsCS6vdobgQmyYLOfbp7wmSn1FTz9ugEAGLh0Gs+R?=
 =?us-ascii?Q?/VMlkvGJUix+Eau+r9GiRpU1K2qQnIgvlk8L+6+l+I0Ox+S3ZBQOJ7QKC07Q?=
 =?us-ascii?Q?MOzuxUIz65uomEPPdzvbeflT1sGq4dPXaW2FGP++/BRtEoycjjOqzdbtF0tP?=
 =?us-ascii?Q?/4nf2nyA0C9Cxim0JzElTovPDrw724zMHAgfULSMJoQ/KI9d8C51aH8CRizx?=
 =?us-ascii?Q?IGv8ICohq7Q53zlVNZy1KQoihRjGqr+3Rqfh1NoKQHqFO7i+qRBhVdpcdrmH?=
 =?us-ascii?Q?7Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73b3000a-4753-4296-8b4b-08db1a693188
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 15:25:30.9227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gP4MoGJ9rDfOn9aVfLMl/ocib+iLYUc2zUIlsRkFhaJAClclcmt4FFmmwiXz9+TlhUVSp21ttNnX7eazsN7pWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9871
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 01, 2023 at 05:09:41PM +0200, Andy Shevchenko wrote:
> With overlays you can create the proper DT description stanza and end user's
> job is to just put it somewhere and upload via precoded script or so [1].
> 
> [1]:https://docs.kernel.org/devicetree/overlay-notes.html

Ah, okay, no, that's already a no-go, since existing device tree blobs
aren't compiled with the dtc "-@" flag which would generate the __symbols__
node necessary for DT overlays to be applied over them.

That, and it's clunky and uncalled for in general, both from my
perspective as a driver developer and that of a random user, if a driver
would just start requiring device tree overlays for more functionality.
Overlays address none of the complaints I had with large DT bindings
being large in general. They are still equally large, but now, they are
also spread into multiple files.

> For the second one I'm not really the expert. But either FPGA framework (if
> they have anything working for this), or you also may look at Thunderbolt /
> USB4 which uses similar approach while being PCIe devices. Okay, the latter
> (USB4) is the PCIe topology, while FPGA is whatever behind the PCI switch.
> Meaning that FPGA case from HW p.o.v. is closer to your case.

A quick glance at Documentation/driver-api/fpga/ shows that it is a
framework for dealing with reprogrammable hardware, and has infra to
reprogram it. My hardware is fixed-function and doesn't need any of that.

Are you suggesting that I should look at reusing some common infra with
the fpga subsystem instead? A quick grep for device_add in drivers/fpga/
shows a bunch of open-coded device_add() and platform_device_add() calls.
Is this what you wanted me to see or is there something else?