Date:   Wed, 1 Mar 2023 17:34:44 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     Daniel Scally <djrscally@gmail.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Implementation of fwnode_operations :: device_get_match_data()
 for software nodes?
Message-ID: <Y/9wlDkuh39auAgF@smile.fi.intel.com>
References: <20230223203713.hcse3mkbq3m6sogb@skbuf>
 <Y/0uC1LgeWR0V0ts@smile.fi.intel.com>
 <20230227234411.jqmwshzkeyx6iqyo@skbuf>
 <Y/9iLBWAO37y6lZZ@smile.fi.intel.com>
 <20230301143625.7kdnzujlv4psbhla@skbuf>
 <Y/9qtT0vckSikOKJ@smile.fi.intel.com>
 <20230301152527.khyzifds4w3rkebt@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230301152527.khyzifds4w3rkebt@skbuf>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Mar 01, 2023 at 05:25:27PM +0200, Vladimir Oltean wrote:
> On Wed, Mar 01, 2023 at 05:09:41PM +0200, Andy Shevchenko wrote:
> > With overlays you can create the proper DT description stanza and end user's
> > job is to just put it somewhere and upload via precoded script or so [1].
> > 
> > [1]:https://docs.kernel.org/devicetree/overlay-notes.html
> 
> Ah, okay, no, that's already a no-go, since existing device tree blobs
> aren't compiled with the dtc "-@" flag which would generate the __symbols__
> node necessary for DT overlays to be applied over them.
> 
> That, and it's clunky and uncalled for in general, both from my
> perspective as a driver developer and that of a random user, if a driver
> would just start requiring device tree overlays for more functionality.
> Overlays address none of the complaints I had with large DT bindings
> being large in general. They are still equally large, but now, they are
> also spread into multiple files.

But isn't it what you would like to have working for your case?

Even taking into account the fixed HW layout, it would make sense to have more
flexible approach to describe it, no?

> > For the second one I'm not really the expert. But either FPGA framework (if
> > they have anything working for this), or you also may look at Thunderbolt /
> > USB4 which uses similar approach while being PCIe devices. Okay, the latter
> > (USB4) is the PCIe topology, while FPGA is whatever behind the PCI switch.
> > Meaning that FPGA case from HW p.o.v. is closer to your case.
> 
> A quick glance at Documentation/driver-api/fpga/ shows that it is a
> framework for dealing with reprogrammable hardware, and has infra to
> reprogram it. My hardware is fixed-function and doesn't need any of that.
> 
> Are you suggesting that I should look at reusing some common infra with
> the fpga subsystem instead? A quick grep for device_add in drivers/fpga/
> shows a bunch of open-coded device_add() and platform_device_add() calls.
> Is this what you wanted me to see or is there something else?

Ah, so they don't have a mechanism on how to describe the hardware inside
FPGA _after_ reconfiguration and apply it to the system? That's what I meant
when referred to it.

-- 
With Best Regards,
Andy Shevchenko