Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966047AbXILKSP (ORCPT ); Wed, 12 Sep 2007 06:18:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933119AbXILKSA (ORCPT ); Wed, 12 Sep 2007 06:18:00 -0400 Received: from smtp.ocgnet.org ([64.20.243.3]:54647 "EHLO smtp.ocgnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933046AbXILKR7 (ORCPT ); Wed, 12 Sep 2007 06:17:59 -0400 Date: Wed, 12 Sep 2007 19:17:45 +0900 From: Paul Mundt To: Michael Buesch Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y Message-ID: <20070912101745.GA23417@linux-sh.org> Mail-Followup-To: Paul Mundt , Michael Buesch , Andrew Morton , linux-kernel@vger.kernel.org References: <20070912021100.GB26827@linux-sh.org> <200709121209.10068.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709121209.10068.mb@bu3sch.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1759 Lines: 40 On Wed, Sep 12, 2007 at 12:09:09PM +0200, Michael Buesch wrote: > On Wednesday 12 September 2007 04:11:00 Paul Mundt wrote: > > SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to > > build in PCMCIA support or not, as the PCMCIA host code itself is > > also only a bool, make SSB_PCMCIAHOST_POSSIBLE depend on PCMCIA=y. > > > > Without this, SSB_PCMCIAHOST_POSSIBLE evaluates to y when PCMCIA > > is built as a module, which results in link errors due to the > > pcmcia_access_configuration_register() accesses, where the symbol > > is only defined in a module. > > > > --- linux-2.6.23-rc4-mm1.orig/drivers/ssb/Kconfig 2007-09-11 15:15:52.000000000 +0900 > > +++ linux-2.6.23-rc4-mm1/drivers/ssb/Kconfig 2007-09-12 10:51:53.000000000 +0900 > > @@ -37,7 +37,7 @@ > > > > config SSB_PCMCIAHOST_POSSIBLE > > bool > > - depends on SSB && PCMCIA && EXPERIMENTAL > > + depends on SSB && PCMCIA=y && EXPERIMENTAL > > default y > > > > config SSB_PCMCIAHOST > > > > > > There we go. The usual SELECT dependency hell again... > Would changing SSB_PCMCIAHOST_POSSIBLE to tristate also fix it? > What would be the sideeffects? > I tried that first, if you do that you have to change the default to SSB && PCMCIA, and then anything that depends on it also has to be a tristate. That worked ok for SSB_PCMCIAHOST, but it didn't work ok for the b43 wireless + PCMCIA, which is why I opted for the PCMCIA=y thing instead, which makes sure that SSB_PCMCIAHOST can't be enabled if PCMCIA is modular. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/