Date:   Wed, 1 Mar 2023 17:52:58 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
        jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, deller@gmx.de,
        geert+renesas@glider.be, phil.edworthy@renesas.com,
        matthew.gerlach@linux.intel.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH tty-next] serial: 8250_pci1xxxx: Disable
 SERIAL_8250_PCI1XXXX config by default
Message-ID: <Y/902nTSA05VY3i5@smile.fi.intel.com>
References: <20230301100930.3519883-1-kumaravel.thiagarajan@microchip.com>
 <Y/82Ehzj2+FgIRh3@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/82Ehzj2+FgIRh3@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > Disable SERIAL_8250_PCI1XXXX config by default
> 
> Why?
> 
> Please read the kernel documentation for how to write a good changelog
> text.

Kumaravel, hint for you: Take what Linus had written in the discussion of
Greg's pull request. It mainly explains it all.

> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> 
> What commit id does this fix?

Another hint: this lacks so called Fixes tag. You may read about it in the
documentation.

-- 
With Best Regards,
Andy Shevchenko