Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A89C64ED6 for ; Wed, 1 Mar 2023 16:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjCAQaS (ORCPT ); Wed, 1 Mar 2023 11:30:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbjCAQ3z (ORCPT ); Wed, 1 Mar 2023 11:29:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E16460BF; Wed, 1 Mar 2023 08:29:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9D42B810B5; Wed, 1 Mar 2023 16:29:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD0AEC433D2; Wed, 1 Mar 2023 16:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677688187; bh=dgq8To5gJjy6B/8pGTldW8mR7VgXGg7MezcnU3DYKXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LXxc3GVgLcLgiEmQ4VlMfgYra1BqNpfxQcgNt+Ve4WpdyCSsFPnY8ZK0gUCJKItVa Ue3LYbYEHR0qhkWv9AsTArzXa5IPuAc60Fj/F7XA8Lu7maJGrmJGRja96GU+Lg0UNq Jq2+zdlBjHRVXwwsNWhtpDZx/8zG1ibRZdLGN1vF7b2JzqtexzxoQ9fQ8vs/B9Gb7P 00/HVEM5fEQY/dSfBcMHl/fr/JvLjDbk/mzDnCTRSnuyYZ5wrrvM3KiunqtbHnNmM9 pepI1k+Ar1B4CKH/ebrvjkiUj/72aMQfZfecZdj8SDuJi/7/y8sD7PhHE8J+yZ0se5 s4pNnr+I2QrLg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Charles Keepax , Lee Jones , Sasha Levin , patches@opensource.cirrus.com Subject: [PATCH AUTOSEL 6.1 6/6] mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak Date: Wed, 1 Mar 2023 11:29:38 -0500 Message-Id: <20230301162938.1302886-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230301162938.1302886-1-sashal@kernel.org> References: <20230301162938.1302886-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He [ Upstream commit 4414a7ab80cebf715045e3c4d465feefbad21139 ] In arizona_clk32k_enable(), we should use pm_runtime_resume_and_get() as pm_runtime_get_sync() will increase the refcnt even when it returns an error. Signed-off-by: Liang He Acked-by: Charles Keepax Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20230105061055.1509261-1-windhl@126.com Signed-off-by: Sasha Levin --- drivers/mfd/arizona-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index cbf1dd90b70d5..b1c53e0407710 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -45,7 +45,7 @@ int arizona_clk32k_enable(struct arizona *arizona) if (arizona->clk32k_ref == 1) { switch (arizona->pdata.clk32k_src) { case ARIZONA_32KZ_MCLK1: - ret = pm_runtime_get_sync(arizona->dev); + ret = pm_runtime_resume_and_get(arizona->dev); if (ret != 0) goto err_ref; ret = clk_prepare_enable(arizona->mclk[ARIZONA_MCLK1]); -- 2.39.2