Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966636AbXILLIf (ORCPT ); Wed, 12 Sep 2007 07:08:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764391AbXILLI2 (ORCPT ); Wed, 12 Sep 2007 07:08:28 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:63059 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763595AbXILLI1 (ORCPT ); Wed, 12 Sep 2007 07:08:27 -0400 From: Arnd Bergmann To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded Date: Wed, 12 Sep 2007 13:04:57 +0200 User-Agent: KMail/1.9.6 (enterprise 0.20070831.706792) Cc: Michael Ellerman , Jeremy Kerr , linux-kernel@vger.kernel.org References: <2900ea4dbfd6e98e71ff400cbd25d1283a278972.1189583010.git.michael@ellerman.id.au> <628a383203480c3ce59125feccc32168de919014.1189583010.git.michael@ellerman.id.au> In-Reply-To: <628a383203480c3ce59125feccc32168de919014.1189583010.git.michael@ellerman.id.au> X-Face: >j"dOR3XO=^3iw?0`(E1wZ/&le9!.ok[JrI=S~VlsF~}"P\+jx.GT@=?utf-8?q?=0A=09-oaEG?=,9Ba>v;3>:kcw#yO5?B:l{(Ln.2)=?utf-8?q?=27=7Dfw07+4-=26=5E=7CScOpE=3F=5D=5EXdv=5B/zWkA7=60=25M!DxZ=0A=09?= =?utf-8?q?8MJ=2EU5?="hi+2yT(k`PF~Zt;tfT,i,JXf=x@eLP{7B:"GyA\=UnN) =?utf-8?q?=26=26qdaA=3A=7D-Y*=7D=3A3YvzV9=0A=09=7E=273a=7E7I=7CWQ=5D?=<50*%U-6Ewmxfzdn/CK_E/ouMU(r?FAQG/ev^JyuX.%(By`" =?utf-8?q?L=5F=0A=09H=3Dbj?=)"y7*XOqz|SS"mrZ$`Q_syCd MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709121304.58140.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/Aklu0QdxAiGmyK2nybsO9XISDL9ncePgXvRr agAF486fUfCPjeIuJgtRGs1G4xB3fIVUe52kbFB2v5Q6vm4Jlw IZGGH84zjI0xLFu2mfJPA== Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 20 On Wednesday 12 September 2007, Michael Ellerman wrote: > Because the SPU coredump code might be built as part of a module (spufs), > we have a stub which is called by the coredump code, this routine then calls > into spufs if it's loaded. > > Unfortunately the stub returns -ENOSYS if spufs is not loaded, which is > interpreted by the coredump code as an extra note size of -38 bytes. This > leads to a corrupt core dump. > > If spufs is not loaded there will be no SPU ELF notes to write, and so the > extra notes size will be == 0. > > Signed-off-by: Michael Ellerman Acked-by: Arnd Bergmann - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/