Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF2AC6FA9D for ; Wed, 1 Mar 2023 18:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbjCASOI (ORCPT ); Wed, 1 Mar 2023 13:14:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjCASOF (ORCPT ); Wed, 1 Mar 2023 13:14:05 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C60028840 for ; Wed, 1 Mar 2023 10:13:59 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id ec43so57458674edb.8 for ; Wed, 01 Mar 2023 10:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1677694437; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6/asb3PYi302CsLXOXWpBQTKIfyQX2PG5Qj/oLUdH5k=; b=VcEiiaTfxPmiqwXoecvpahehdctu63BLGW4saFO/UrTcs1beWBHcWiztIw4qeMLbtN UDhVjdTYZ+U8fsUpZKjsT4dWBeA5xIObDM5vZ0oqdg6xFxGAE/ONB29DGc4bgwj08Yi/ pe4O9bVEPFq8625OTiGntkymQ9EyiAsiFSpUs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677694437; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6/asb3PYi302CsLXOXWpBQTKIfyQX2PG5Qj/oLUdH5k=; b=D4G9uEP3nJaWsGCnq60BBORDXfo6YdTRCruKWhbgiem63qwBA1XHsyMi5EiJRBQlzj aj9/leoSYmI7dDQ2bddLW3NI/AAcldIqlN0/ez3siR//r/Gg2JRC8LJ2VLX5I5Cykri+ XjJbamFWoKzoFdBPrqKYsQQCOhiAZ5HNGePUILogD02qL+kgys+mOv4cDcvcZ+JFKkQw ODJQG/2IYx4UrD/e6wCoh+AjX93a27T/Tgj8QUqw5DpTAsYvE0rgd9QBRTnh95T2DdJP fSJpeMCByVRd6TaiI18tUrVD/7XkJp40TCjl9qxMbUnIeT+EFK/Xl9ETmsMwICk36VY6 1lfg== X-Gm-Message-State: AO0yUKUUtrDUvm57SRfbHX7ooecGjPgJs2jcj2oEg0krOmVCdJGu7fy2 S3Ey2DvjZZw30YAHjFiQANtA4xvj2j9dbpT4vdTlyg== X-Google-Smtp-Source: AK7set/MmIHzJy3FIvKLR2RVAKtiYeuRH3MEUqCUgiuUvRz3qLqMIQAkaVcoQjR71a4HkmS1BHoJTA== X-Received: by 2002:aa7:c9d9:0:b0:4ab:1625:908d with SMTP id i25-20020aa7c9d9000000b004ab1625908dmr8249940edt.16.1677694437379; Wed, 01 Mar 2023 10:13:57 -0800 (PST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id n28-20020a50935c000000b004bc15a440f1sm1112330eda.78.2023.03.01.10.13.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Mar 2023 10:13:56 -0800 (PST) Received: by mail-ed1-f50.google.com with SMTP id u9so7988532edd.2 for ; Wed, 01 Mar 2023 10:13:56 -0800 (PST) X-Received: by 2002:a17:906:2ec8:b0:877:747e:f076 with SMTP id s8-20020a1709062ec800b00877747ef076mr3586877eji.0.1677694436076; Wed, 01 Mar 2023 10:13:56 -0800 (PST) MIME-Version: 1.0 References: <20230125155557.37816-1-mjguzik@gmail.com> <97465c08-7b6e-7fd7-488d-0f677ac22f81@schaufler-ca.com> In-Reply-To: From: Linus Torvalds Date: Wed, 1 Mar 2023 10:13:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] capability: add cap_isidentical To: Mateusz Guzik Cc: Casey Schaufler , Serge Hallyn , viro@zeniv.linux.org.uk, paul@paul-moore.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2023 at 1:29=E2=80=AFPM Linus Torvalds wrote: > > That said, the old code was worse. The only redeeming feature of the > old code was that "nobody has touched it in ages", so it was at least > stable. Bah. I've walked through that patch something like ten times now, and decided that there's no way it breaks anything. Famous last words. It also means that I don't want to look at that ugly old code when I have the fix for it all, so I just moved it over from my experimental tree to the main tree, since it's still the merge window. Quod licet Iovi, non licet bovi, or something. Linus