Date:   Wed, 1 Mar 2023 18:21:26 +0000
From:   Mark Brown <broonie@kernel.org>
To:     dhruva gole <d-gole@ti.com>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        Pratyush Yadav <ptyadav@amazon.de>, linux-spi@vger.kernel.org,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-sn-f-ospi: fix white spaces and improve code
 formatting
Message-ID: <Y/+XpoWFBUkdhPYh@sirena.org.uk>
References: <20230223102918.985376-1-d-gole@ti.com>
 <Y/y5mHklSYINwnA5@sirena.org.uk>
 <067ff1a3-a00a-9e19-9c6f-8d446915efe9@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wfm4XllFJqu+VQRR"
Content-Disposition: inline
In-Reply-To: <067ff1a3-a00a-9e19-9c6f-8d446915efe9@ti.com>
Precedence: bulk


--wfm4XllFJqu+VQRR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 01, 2023 at 10:49:31AM +0530, dhruva gole wrote:
> On 27/02/23 19:39, Mark Brown wrote:
> > On Thu, Feb 23, 2023 at 03:59:18PM +0530, Dhruva Gole wrote:

> > > Allignment issues in all the macro definitions of this driver have been
> > > fixed for better asthetics

> > In what way?

> In my humble opinion, the spacing between the MACRO names

> and their values seemed a bit OFF. Like there lacked

> consistency for example:

> OSPI_PROT_MODE_QUAD			2
> OSPI_PROT_MODE_OCTAL		3

> Here we can see 3 is at a shorter length compared to 2 from their respective macros.

These look perfectly lined up for me.  I suspect you may have your tab
size set to something other than 8.

--wfm4XllFJqu+VQRR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP/l6YACgkQJNaLcl1U
h9C/5Qf+PXcuRjOeh6VItzYbjCCDUMt4FRzOmMxWzofzFDEnGe3wpTLhHnI+llqy
BVEvdTo0TV1idw68Eth6FgYIMnqDeKs6d9DFaVp80JqktanlJZfns0XmMlKijTqM
JdcBZEFKZr8/CMvosmg8qDwWBa6Hsq7Lz/6D1zayMXvg/iF1Or6wh3L+jCfgBcdf
Uk8/g2i4sqakd7zMJGbGcV8PTtSBMcx5yJIcXCsdNs81SrPmdrX//gicmZBQH28l
bxvKbheWohwzKGyl6oVS5W2k5pjOgTte4ym7JPl6J9dWrPXG9Hm+nH1NoEn6VWdu
AN0JctJkLg6CnSVz/988G+/JARAwOg==
=yHzB
-----END PGP SIGNATURE-----

--wfm4XllFJqu+VQRR--