MIME-Version: 1.0
References: <20230228155121.3416-1-ubizjak@gmail.com> <Y/5mguXPPqdP3MZF@google.com>
 <20230228160324.2a7c1012@gandalf.local.home> <20230228212911.GX2948950@paulmck-ThinkPad-P17-Gen-1>
 <20230228164124.77c126d2@gandalf.local.home> <CAEXW_YQ515_DOLVUm48GvDADuaY2mSrYTaKa7u6jYDNqBncJww@mail.gmail.com>
 <20230228190846.79b06089@gandalf.local.home> <CAFULd4aY3Y8tyLN70oebZDagBebvH0erwRxKDaEX8L83Xo8gYw@mail.gmail.com>
 <20230301113813.4f16a689@gandalf.local.home>
In-Reply-To: <20230301113813.4f16a689@gandalf.local.home>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Wed, 1 Mar 2023 19:43:34 +0100
Message-ID: <CAFULd4aWZ+fvVZ+MEt6JD1rFaQZeO5DDWAHtPKOrx8R8DETFBw@mail.gmail.com>
Subject: Re: [PATCH] rcu: use try_cmpxchg in check_cpu_stall
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Joel Fernandes <joel@joelfernandes.org>,
        "Paul E. McKenney" <paulmck@kernel.org>, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Frederic Weisbecker <frederic@kernel.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000008f74f605f5db173f"
Precedence: bulk

--0000000000008f74f605f5db173f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 1, 2023 at 5:38=E2=80=AFPM Steven Rostedt <rostedt@goodmis.org>=
 wrote:
>
> On Wed, 1 Mar 2023 11:28:47 +0100
> Uros Bizjak <ubizjak@gmail.com> wrote:
>
> > These benefits are the reason the change to try_cmpxchg was accepted
> > also in the linear code elsewhere in the linux kernel, e.g. [2,3] to
> > name a few commits, with a thumbs-up and a claim that the new code is
> > actually *clearer* at the merge commit [4].
>
> I'll say it here too. I really like Joel's suggestion of having a
> cmpxchg_success() that does not have the added side effect of modifying t=
he
> old variable.
>
> I think that would allow for the arch optimizations that you are trying t=
o
> achieve, as well as remove the side effect that might cause issues down t=
he
> road.

Attached patch implements this suggestion.

Uros.

--0000000000008f74f605f5db173f
Content-Type: text/plain; charset="US-ASCII"; name="rcu-2.diff.txt"
Content-Disposition: attachment; filename="rcu-2.diff.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_leq1061i0>
X-Attachment-Id: f_leq1061i0

ZGlmZiAtLWdpdCBhL2tlcm5lbC9yY3UvdHJlZV9zdGFsbC5oIGIva2VybmVsL3JjdS90cmVlX3N0
YWxsLmgKaW5kZXggYjEwYjgzNDliYjJhLi4yMjkyNjNlYmJhM2IgMTAwNjQ0Ci0tLSBhL2tlcm5l
bC9yY3UvdHJlZV9zdGFsbC5oCisrKyBiL2tlcm5lbC9yY3UvdHJlZV9zdGFsbC5oCkBAIC03MDks
NiArNzA5LDEyIEBAIHN0YXRpYyB2b2lkIHByaW50X2NwdV9zdGFsbCh1bnNpZ25lZCBsb25nIGdw
cykKIAlzZXRfcHJlZW1wdF9uZWVkX3Jlc2NoZWQoKTsKIH0KIAorI2RlZmluZSBjbXB4Y2hnX3N1
Y2Nlc3MocHRyLCBvbGQsIG5ldykJCQkJXAorKHsJCQkJCQkJCVwKKwlfX3R5cGVvZl9fKCoocHRy
KSkgX190bXAgPSAob2xkKTsJCQlcCisJdHJ5X2NtcHhjaGcoKHB0ciksICZfX3RtcCwgKG5ldykp
OwkJCVwKK30pCisKIHN0YXRpYyB2b2lkIGNoZWNrX2NwdV9zdGFsbChzdHJ1Y3QgcmN1X2RhdGEg
KnJkcCkKIHsKIAlib29sIGRpZHN0YWxsID0gZmFsc2U7CkBAIC03NjAsNyArNzY2LDcgQEAgc3Rh
dGljIHZvaWQgY2hlY2tfY3B1X3N0YWxsKHN0cnVjdCByY3VfZGF0YSAqcmRwKQogCWpuID0gamlm
ZmllcyArIFVMT05HX01BWCAvIDI7CiAJaWYgKHJjdV9ncF9pbl9wcm9ncmVzcygpICYmCiAJICAg
IChSRUFEX09OQ0Uocm5wLT5xc21hc2spICYgcmRwLT5ncnBtYXNrKSAmJgotCSAgICBjbXB4Y2hn
KCZyY3Vfc3RhdGUuamlmZmllc19zdGFsbCwganMsIGpuKSA9PSBqcykgeworCSAgICBjbXB4Y2hn
X3N1Y2Nlc3MoJnJjdV9zdGF0ZS5qaWZmaWVzX3N0YWxsLCBqcywgam4pKSB7CiAKIAkJLyoKIAkJ
ICogSWYgYSB2aXJ0dWFsIG1hY2hpbmUgaXMgc3RvcHBlZCBieSB0aGUgaG9zdCBpdCBjYW4gbG9v
ayB0bwpAQCAtNzc4LDcgKzc4NCw3IEBAIHN0YXRpYyB2b2lkIGNoZWNrX2NwdV9zdGFsbChzdHJ1
Y3QgcmN1X2RhdGEgKnJkcCkKIAogCX0gZWxzZSBpZiAocmN1X2dwX2luX3Byb2dyZXNzKCkgJiYK
IAkJICAgVUxPTkdfQ01QX0dFKGosIGpzICsgUkNVX1NUQUxMX1JBVF9ERUxBWSkgJiYKLQkJICAg
Y21weGNoZygmcmN1X3N0YXRlLmppZmZpZXNfc3RhbGwsIGpzLCBqbikgPT0ganMpIHsKKwkJICAg
Y21weGNoZ19zdWNjZXNzKCZyY3Vfc3RhdGUuamlmZmllc19zdGFsbCwganMsIGpuKSkgewogCiAJ
CS8qCiAJCSAqIElmIGEgdmlydHVhbCBtYWNoaW5lIGlzIHN0b3BwZWQgYnkgdGhlIGhvc3QgaXQg
Y2FuIGxvb2sgdG8K
--0000000000008f74f605f5db173f--