Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A577C7EE2F for ; Wed, 1 Mar 2023 18:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbjCAS7N (ORCPT ); Wed, 1 Mar 2023 13:59:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjCAS7M (ORCPT ); Wed, 1 Mar 2023 13:59:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1940B1EFF5; Wed, 1 Mar 2023 10:59:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A927E61448; Wed, 1 Mar 2023 18:59:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0EE5C433D2; Wed, 1 Mar 2023 18:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677697150; bh=GD4ue5id52LPJqSDQUoM8gDAQWL7Hip/zzpyh7tgYew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W7MyJIWA1O8XhpkDCLO6bPeFT4poEczvttXqZOfJrQVq32kClh1rBTxZNc0BkErkY jy/FFM7AvtfEnjuhwB1u/ksYzgbyakyeaR0gCe9m2b6QRVlEJUUh7/m81irDtBHkpL 6hAvHeCBoe+4p/a2sBjp67w5Qr+7M9aW61lx9s1YQ6IIQxJsGWos9DAQjVZYS0s2hL 1QZSMMnh/wyed4f6FJSlqcwqIxqfvXjSQ64gaRqYI6yxoKCdLy/AXRCl7q+prfCPRi Bf9DsLWrfzuaJlyPzGe6/+60cPwfBpBNWdaKS7Rd06tEFfG9u4VzX4cJUK9M5hYxCj 8qg/QM03broFA== Date: Wed, 1 Mar 2023 13:59:08 -0500 From: Sasha Levin To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Johan Hovold , linux-efi@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.2 2/6] efi: efivars: prevent double registration Message-ID: References: <20230301162929.1302785-1-sashal@kernel.org> <20230301162929.1302785-2-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 01, 2023 at 05:31:15PM +0100, Ard Biesheuvel wrote: >On Wed, 1 Mar 2023 at 17:29, Sasha Levin wrote: >> >> From: Johan Hovold >> >> [ Upstream commit 0217a40d7ba6e71d7f3422fbe89b436e8ee7ece7 ] >> >> Add the missing sanity check to efivars_register() so that it is no >> longer possible to override an already registered set of efivar ops >> (without first deregistering them). >> >> This can help debug initialisation ordering issues where drivers have so >> far unknowingly been relying on overriding the generic ops. >> >> Signed-off-by: Johan Hovold >> Signed-off-by: Ard Biesheuvel >> Signed-off-by: Sasha Levin > >NAK this is not a bugfix. Ack, I'll drop it. Thanks! -- Thanks, Sasha