Message-ID: <4418ac5b-bdca-6a8d-16b1-302568482350@intel.com>
Date:   Wed, 1 Mar 2023 14:27:10 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net v3] ice: copy last block omitted in
 ice_get_module_eeprom()
Content-Language: en-US
To:     Petr Oros <poros@redhat.com>, <netdev@vger.kernel.org>
CC:     <aleksander.lobakin@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <scott.w.taylor@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230301204707.2592337-1-poros@redhat.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230301204707.2592337-1-poros@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2xvdkxDdUszUnJZdVl4bzVyOU9EL01EbkRySkhoT1htK1E4YmxwNEl5OVpZ?=
 =?utf-8?B?MTgzVUp5WEYycGZqaTh1ajRBV28vUldkRUxlenJxOTN6aDJ5M3Z3TTdjSU1t?=
 =?utf-8?B?RlBqMTl6Z0hEUHJFWHNrbmk5bW9SbGJ1NFhaOVg0K2ZENXdFYVh3M2NscWpH?=
 =?utf-8?B?cmRBbUwzYm1XR3EzTmlpcCt5dCtQbXRrM0s2OGtFeDRGZXRBdHIwVlBHdStJ?=
 =?utf-8?B?bmpwTkdJWlFHcmRpWWVxZi9aYXVvcG10bTQ0SlVqTXBZRlJkS3JzcFRkS093?=
 =?utf-8?B?YUswRm56TmY5amRhTEJhZU12TlFMUEtvV0Vub0hVS2lXZzBrZnkvaWYrNVU4?=
 =?utf-8?B?aWtVMDdoVjlYUkxXNUZQdWc2NnN2NTkxUmw2QWk0TmdCWlRGemQ5aHpmZ3dz?=
 =?utf-8?B?SC9FMFI2S0hvM05YQzl1MDVNcGlJcTlPYml2OXJ2ZDZWUVB3bW1pdjJ2UGdB?=
 =?utf-8?B?Y3o3dCtGM1N1V1o2MG01N0poUlBGMmpqWTFDR3VVeGczWVVLNERRVDhDMU9Y?=
 =?utf-8?B?OWZTbG16T2RBZ3JWQnE5VSt5UEhHWEw1U253UWhrWFd1R2lYK0gzRDNYMVRV?=
 =?utf-8?B?VUtWc3N2MUtIWk1KcjQ5UzRja0NYV2tGdnRuamE4OU9zRDhDcS96eXA2NG9H?=
 =?utf-8?B?aDNXUFYvVmk3UStlcmFabkRMOXhJVjh1MHZzTDZGOU1HVVplVC9ybldmeGds?=
 =?utf-8?B?MDg4WFpYSHpWWVlyQTBCUmNpUXRGM1lNWjYxVFRYbERHTXlyaUhmNXZWV2Zn?=
 =?utf-8?B?UG52WWtEYWswUUNiRDVEblk0aEhYUGhsbDNrRkU4cDh6OFo1V3o5OHB1S0xC?=
 =?utf-8?B?KzNuSGdrbUo0TFdOaC95b0xaTmQzMHl5eGZFMDlRVmJsTE12VURmRnQvaEp4?=
 =?utf-8?B?VWthb3kybm9qK2cwcGpqbVJOMFJMNjlrUTNkdXdRQk9GKzhiczBxVDBxaU5T?=
 =?utf-8?B?ZEJIMEdzMTVLbmlnZmNWQ1JwckhxekErS1JPRWhiVWdZdmJVT08zRGRWR1Rj?=
 =?utf-8?B?dDVvb3NqMXgwM0t1SDY0em9mUEwyakNXZHl0RzI0NjZ5U2NZQ3pzSnRYRDFO?=
 =?utf-8?B?VVk4NGhMWlZMbmRLMjZvSjAwdmhTQU9MSnk2em5hQ1RXdWhKc3ZXbGpORjI1?=
 =?utf-8?B?NzZhMHYzSklLRkxJdHZ2SnZzQ0xvYjY5R3VQSjFEN1BrdUY3RUtFRy9YVUt3?=
 =?utf-8?B?dUczQlBVSkV5RzZpRG1vekZlM3FVNUJaTDkwTHlYdSt2TEtGM3FaUlIycytl?=
 =?utf-8?B?alVQV1g4bkI4bkczd0xpT3psbW9wTERMMGlOckUzRzRYN09oWkpHVzBxL0hJ?=
 =?utf-8?B?SDk2Ynp6QWlEdzhwangrNkxYTmErOHlHMkZyNzVLcm5PRmliU2c2cHhGV1Jv?=
 =?utf-8?B?U1hhMHNERldrL3o1M2MwN2ttSlBEMk5UbEtUMUxzbGdCenY4ZFpMaTBqQnBt?=
 =?utf-8?B?NVp5b3Z2SXVmb0FWZWQvQU9WREE4dHpwUVJIL25kSzc3dnNnN05xcEc5azQy?=
 =?utf-8?B?VVVicDB6NUhrd1M5UitldmFhOERqTnYzR1hmdW1hSUw0d0l5ZDFGSDF5V1ps?=
 =?utf-8?B?ZEN0UFl1R04yRVBqbExaRzhSeVVNNC95bEplQXcxcmVwRTRwRVBGUCs0SmYv?=
 =?utf-8?B?M3BNaEFSb0lOSy9MV1JLb2V1dGlZMU4yRWQ1SlJFRmNsUjdOWGg2ODkrVWV6?=
 =?utf-8?B?TFJNZXo1bnNhNHQwNHRTMVBzWjJuQlBuLzZhL3ZLTmtSTFE1Y0k5Rzl5MzRW?=
 =?utf-8?B?NUIxUG55bmw1MTBGdWl5T3NzbnFyVVE2d2JrZjN0b3hQY3JmdXExVW82RU1Y?=
 =?utf-8?B?bEZ3MENZcUh3cmU4VVNFZlZmUGkwSFZBN3pUSEVGRzZ1eDd6cWVEVWVvYmsz?=
 =?utf-8?B?blRMci9XWCtYeFVON2IwR242YjlYcitlNk5oS0dHdjlxWWNMcjB2VHZnMk45?=
 =?utf-8?B?NUxjamF6L3d6YlpYVTQxMWt5ZDNkclE1RlZ2MVA0eFprOE5GOVZ4S0RUeW1V?=
 =?utf-8?B?SWs5T2xscG5IS014Mm0ydnhHdFBOamNGZEdkaUlrNDYza1VLVUk0NU5TSHdm?=
 =?utf-8?B?cEJEb01Yb1pick9JRTFqdlZvNHpvdGZyc0VwekdWNWFwdk01OVcxYmowa3hz?=
 =?utf-8?B?a21GMjlUVjdyV3ozZnhPbjBtUHAydGlUOElhVnhnU01CWmd0dS9CTy9vRGFS?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69416ad5-bf62-4e16-4d27-08db1aa41afe
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 22:27:13.5389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TvmzblEziKeK7AN0ASfC4t1VQhGc2PVd5y5T7SXGTP9ZPSIyYgt2FahmScVlha8DWuKe3rJOKg1J/ybNH9KfO4QXZFJ6MwNy76lxEZCPT5I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7134
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/1/2023 12:47 PM, Petr Oros wrote:
> ice_get_module_eeprom() is broken since commit e9c9692c8a81 ("ice:
> Reimplement module reads used by ethtool") In this refactor,
> ice_get_module_eeprom() reads the eeprom in blocks of size 8.
> But the condition that should protect the buffer overflow
> ignores the last block. The last block always contains zeros.

...

> 
> Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool")
> Signed-off-by: Petr Oros <poros@redhat.com>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Thanks Petr!