Message-ID: <753264d7-a236-0f1d-bb6f-328f5f8c7c0a@quicinc.com>
Date:   Wed, 1 Mar 2023 15:59:11 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 0/2] Validating UAPI backwards compatibility
Content-Language: en-US
To:     Mark Wielaard <mark@klomp.org>
CC:     Nick Desaulniers <ndesaulniers@google.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>,
        <linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Arnd Bergmann" <arnd@arndb.de>,
        Bjorn Andersson <andersson@kernel.org>,
        Todd Kjos <tkjos@google.com>,
        Matthias Maennich <maennich@google.com>,
        Giuliano Procida <gprocida@google.com>,
        <kernel-team@android.com>, <libabigail@sourceware.org>,
        Jordan Crouse <jorcrous@amazon.com>,
        Trilok Soni <quic_tsoni@quicinc.com>,
        Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
        Elliot Berman <quic_eberman@quicinc.com>
References: <20230301075402.4578-1-quic_johmoo@quicinc.com>
 <CAKwvOdmqShYae=DrwP1JZBYXAYZyDB0SaOkVCvCzQC60MaJcpw@mail.gmail.com>
 <41d287fa-3a0a-cac6-4595-ad47ef873d79@quicinc.com>
 <0c92e7b8-e415-8ad5-14e7-d94f18c3fa25@quicinc.com>
 <b2055eab-4762-5fbf-8ea6-0956a0a2eb58@quicinc.com>
 <20230301235233.GJ12496@gnu.wildebeest.org>
From:   John Moon <quic_johmoo@quicinc.com>
In-Reply-To: <20230301235233.GJ12496@gnu.wildebeest.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/1/2023 3:52 PM, Mark Wielaard wrote:
> Hi John,
> 
> On Wed, Mar 01, 2023 at 02:33:00PM -0800, John Moon via Libabigail wrote:
>> With some additional help from Nick offline, we determined that the
>> issue isn't with clang, but with libdw (from elfutils). You need at
>> least libdw version 0.171 for the abidiff tool to work correctly
>> with clang (in this particular case). Ubuntu 18.04 ships with
>> version 0.170.
> 
> I don't remember any specific fixes for clang in libdw for elfutils
> 0.171. But elfutils 0.171 was the first release that supported most of
> DWARF5 (including GNU DebugFission and split dwarf).
> 
>> If there's any interest, it'd be fairly easy to add a check for this
>> condition under the check_deps() function in the script.
> 
> Please do add this check. elfutils 0.170 is almost 6 years old now,
> there have been many, many bug fixes since then (current release is
> 0.188 from Nov 2022).
> 
> Thanks,
> 
> Mark

Okay, I'll add the check in v3 after giving a chance for some other 
reviews. Thanks!