Date:   Wed, 1 Mar 2023 17:11:48 -0800
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Chenyi Qiang <chenyi.qiang@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        Kai Huang <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v12 013/106] KVM: TDX: create/destroy VM structure
Message-ID: <20230302011148.GA2069594@ls.amr.corp.intel.com>
References: <cover.1677484918.git.isaku.yamahata@intel.com>
 <fd52ff91fbce051ecf9781af2e5c54138c995230.1677484918.git.isaku.yamahata@intel.com>
 <e23b30cc-80a1-774f-7d58-a676d989b5ce@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e23b30cc-80a1-774f-7d58-a676d989b5ce@intel.com>
Precedence: bulk

On Wed, Mar 01, 2023 at 03:24:49PM +0800,
Chenyi Qiang <chenyi.qiang@intel.com> wrote:

> >  		return -EINVAL;
> >  	}
> >  
> > +	max_pkgs = topology_max_packages();
> > +	tdx_mng_key_config_lock = kcalloc(max_pkgs, sizeof(*tdx_mng_key_config_lock),
> > +				   GFP_KERNEL);
> > +	if (!tdx_mng_key_config_lock)
> > +		return -ENOMEM;
> > +	for (i = 0; i < max_pkgs; i++)
> > +		mutex_init(&tdx_mng_key_config_lock[i]);
> > +
> >  	/* TDX requires VMX. */
> >  	r = vmxon_all();
> >  	if (!r)
> > @@ -168,3 +600,9 @@ int __init tdx_hardware_setup(struct kvm_x86_ops *x86_ops)
> >  
> >  	return r;
> >  }
> > +
> > +void tdx_hardware_unsetup(void)
> > +{
> 
> To align with tdx_hardware_setup(), add some check like:
> 
> if (!enable_ept || !enable_tdx)
> 	return;
> 

Oh yes, thanks for catching it.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>