Date:   Wed, 1 Mar 2023 20:52:42 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Message-ID: <20230302015242.xi3y53okc4skmonn@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Danilo Krummrich <dakr@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
References: <20230302011035.4928-1-dakr@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230302011035.4928-1-dakr@redhat.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jTbSIX75Txna2lC3PNRJhWNs1kWCLmo14TwnFj5Iee/SCpFau/VLdZPaHWLl?=
 =?us-ascii?Q?LXsEIEc9/KgMelD+vRCPt2xBHI1V/qflRdnshyxqBUrou6aHzWgYo3Y3oacF?=
 =?us-ascii?Q?YV3x4IjHgMOwHiO73ceoH3vkWDZMVHaAVo7TLAmUr1hUOLDtFXPZtsSN3w/0?=
 =?us-ascii?Q?hw/9MAp9rPSy9zeD5gDAP0qTC2e7vDlb469shiH58XJRb2ocfb6keJ5gC/Ea?=
 =?us-ascii?Q?kpeKoFRR5VRUqPQhak8mkcU9lrUdprQPfvu64i4XfRPe335h37c9TUF9dS+X?=
 =?us-ascii?Q?Fu1UA+S8rIPnj67z7p7gGUfNISGhRgAGgnqwCjR4q3rhwjdSFgrjYoHTOe5J?=
 =?us-ascii?Q?lFYF2JvNN7hyISTCxMiwxj+g18krZi54t9zF7hK+q+qYlPbvvTQqzYllEzBQ?=
 =?us-ascii?Q?rix2fIkGWGCoS5NGoOB7XV36rBzrsL4Cno/V7txm2A5AtKTf+0Hyjltu05gG?=
 =?us-ascii?Q?giUxTTBOvZpz6bGsN43el6Cc+tbDM/+LETrI3mtB7Colp0m5CBSGJ/+aqAwO?=
 =?us-ascii?Q?FU7ghcITGf8y2XTIfc8zez6RXD723Sk3sqs6MhJRagB5kNksq2aFx878vt4x?=
 =?us-ascii?Q?4qw0W/z7TOrlPlreGNrXHyPVqsleCM6Kpm/BEO75cAelGF3M/yeB3SwOc3ST?=
 =?us-ascii?Q?Wmok5yZ05mCLRVIvdf983d/C/4gC5mVP3IiXXnc/UO238gZWP58Ykm17ezuf?=
 =?us-ascii?Q?4G88+4INB3lw9PSW1UpNwmWsJbo09yxL+P9+wb3uoyc2tPY+dng0CQm2VloW?=
 =?us-ascii?Q?yTMkFvCEce8V+d/tCU5ENqAjRM722wN9Yyx/dZn24ATVKba5wpCELFdgVY3g?=
 =?us-ascii?Q?i15OnaU97ZxgArrYNQYqjqOhgAVehpabafp7DgPI1qcqB9dQg16HwKBSSOlp?=
 =?us-ascii?Q?Q7wyhkmhdOi2cvLTIrD0K/BVC8IHSP8TTJryu4q//p9MEBi7QBm6ItX/8RjM?=
 =?us-ascii?Q?muSr0aVwJ3reHzo+ZjVDxjxBf8YsJooP4fAdtb8D9DM6LrNH+88iRPNIpc1N?=
 =?us-ascii?Q?6zuxY3r3IjWYcSED0VN9o7NyAwT3+qb5X4UXkczZytUrAcKaGD7Y5uiRrdGN?=
 =?us-ascii?Q?IkJllBgkX8XwUjGYbZW451qIvVL/2/sGZe1gtFORR8+gPikDtZFUc3EAa9nU?=
 =?us-ascii?Q?OpIRW5S+ItGxiK4Et5HxXdqc8dZ0//ShHDJGzTQ0d4w+YwV4pveYXDSDkPmq?=
 =?us-ascii?Q?7p/iGDO383ybEjzFgaylYq4O9XfLsiqG3veiA2A9JzTWVxG8yh7vRZ8GbXuq?=
 =?us-ascii?Q?tldrp4fNM9hCLusxLRL8Ebu+N7OhnfUThVnK7Odkg4gNeL6RvY6Oz3FePKNC?=
 =?us-ascii?Q?1Igy0B/AXj5+dkDK81kiCm0L7GNLK7593WU8c8Vu7whXTh8uVY2fTHQDqB0F?=
 =?us-ascii?Q?ilaD0QIwajspjm+HADYzdI51disRZvl6bOI5H1sU/B71GX27DjNd1Q/S6BiV?=
 =?us-ascii?Q?Ieb4SGQ4yv8otrmzKPAbbstUBVzGYTRVFx+cDZCKX0ogvKT81UYd5wrUVVUd?=
 =?us-ascii?Q?SqlaRXH/3h4wkzKh9ttU/LH+u2nY+vjbuo1fDsLhAnkFSxqh8PO7Wtx8N2WK?=
 =?us-ascii?Q?35eKZgOw1DhdEUmXgf0fhxTtuiXlu2UvLOmwqiAl3UHeY5Rd8WTmoAWjGMO5?=
 =?us-ascii?Q?gg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wIyCcHZp+MWa/ERe/mEd1nIts1wjuwKoQTqEPkyaWc2gl56pT9gSQOs1yWv3ulS4S3+U4gy1ZTMrypFXVJI5oiogUVWnkmrsuQjSRhTGMJyA1IpkOwraClbaIq6N/KvsJAoWnVi/qC/Njupa3D0IUcX8errSPDLcwgXDDw6wdZ2JgL/Q1p92y+dDqX1HRH/bVqXJcVauLETRtfT4xJK8UGnlJx82jumcYnoG5oIfHxPIe2FDYuqow6q7UAYqQv2jUZ/VB65GM6kKiyVPUchE0nCOSTvvBAJhgd5h7EwXqctGU2hzvfDh26gjP3PERbNM5ysSHX87THn+0m4yNEPPvzrqtOb+0MgmcIRZLZhqt5r6rdDsV53szcY3C6QHyMK2mWE2BxU/ysbVqb32lObxtJM1h3hpbQalHfwJztKfdCev4s3JQ4Qrh8U7I/8zP/zmqg/dH3zC8wH29asRhjv38CTQmpN6OyV0vVfh0Pyt3Wtc004Jl0kC4EjVinQie1vme2XoK77/QXdxx6Wnc/tcy6kfeqhBHAsQeztYNTkA9vqn5vRyG36glbFjpfieFBWUfY0vNNZJgwOuNYOdCxDuCqewuuhE4mBx8zHhu8I6/OAVKUj8PC/8N9LiF832nKiBaezUCBeC2UgiTnma15sVRkiQjrlafMaL6lFkfv1KQP7BLQeyLmlHZau6tZwPLRXuiY8xBq5Goagw4YZmleAL8kBc744iQG74v1Pp9UZBSIB1MRC/asvT5xIsY6iZQR4tQBnAq/fTUSCawrux2LGEIZWGgEyo+yIfp+Xsr9kNP2OVKmln01t5FQGITF3K6jEW02Csaq2xlIxPxVtC2PWfhldm99S4sZwTo/JFm1vNkBv6s2w667M5JZJe6Uozj9Qn
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 964a86dc-6f06-4ee6-e306-08db1ac0d123
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 01:52:44.9296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cvYCCiRTN6Z9varTAxmo2AveDOxlXAKpHIMABHqyBr/JaX46yNIj9Yj/vaA0PqkVF9mtj25KqESAoxbjegxKxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5123
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-01_17,2023-03-01_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303020012
X-Proofpoint-ORIG-GUID: gQdRF79rIemAl787gVBZ9KAGzck39PQL
X-Proofpoint-GUID: gQdRF79rIemAl787gVBZ9KAGzck39PQL
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the patch.  This should indeed be exported.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

* Danilo Krummrich <dakr@redhat.com> [230301 20:10]:
> Fix missing EXPORT_SYMBOL_GPL() statement for mas_preallocate().
> 
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
>  lib/maple_tree.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 26e2045d3cda..3bfb8a6f3f6d 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5733,6 +5733,7 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp)
>  	mas_reset(mas);
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(mas_preallocate);
>  
>  /*
>   * mas_destroy() - destroy a maple state.
> -- 
> 2.39.2
>