Message-ID: <7B4C8B8B94D621CB+fbf73a3a-6a10-5fbc-e5e5-87e2f56f6878@uniontech.com>
Date:   Thu, 2 Mar 2023 10:56:10 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v5 1/2] fs/proc: optimize register ctl_tables
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Peng Zhang <zhangpeng362@huawei.com>,
        Joel Granados <j.granados@samsung.com>
Cc:     keescook@chromium.org, yzaikin@google.com, ebiederm@xmission.com,
        willy@infradead.org, kbuild-all@lists.01.org,
        nixiaoming@huawei.com, nizhen@uniontech.com,
        sujiaxun@uniontech.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20220304112341.19528-1-tangmeng@uniontech.com>
 <202203081905.IbWENTfU-lkp@intel.com>
 <Y7xWUQQIJYLMk5fO@bombadil.infradead.org>
 <Y8iKjJYMFRSthxzn@bombadil.infradead.org>
 <Y//4B2Bw4O2umKgW@bombadil.infradead.org>
From:   Meng Tang <tangmeng@uniontech.com>
In-Reply-To: <Y//4B2Bw4O2umKgW@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr7
Precedence: bulk


On 2023/3/2 09:12, Luis Chamberlain wrote:

> That would solve the first part -- the fragile odd checks to bail out
> early.  But not the odd accounting we have to do at times. So it begs
> the question if we can instead deprecate register_sysctl_table() and
> then have a counter for us at all times. Also maybe an even simpler
> alternative may just be to see to have the nr_entries be inferred with
> ARRAY_SIZE() if count_subheaders() == 1? I haven't looked into that yet.
> 
>    Luis
> 
The current difficulty is to get the ARRAY_SIZE() of table->child table.

It would be great if have a better way to solve this problem.

      Meng