Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E26C6FA8E for ; Thu, 2 Mar 2023 04:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjCBEqK (ORCPT ); Wed, 1 Mar 2023 23:46:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjCBEqI (ORCPT ); Wed, 1 Mar 2023 23:46:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E46A2BEF6 for ; Wed, 1 Mar 2023 20:46:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EFE8CB811E1 for ; Thu, 2 Mar 2023 04:46:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66C8DC433EF; Thu, 2 Mar 2023 04:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677732363; bh=qkBNSUUKZTROyRtWiTrl7muwV8AqNVcCJdaU8+3/C5o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H8Q9482i9wwOKeGMoEQ4WOP/s0qf+nAagVwqpSCMNAT12/j8L6G/XBGxaAAbCavBG 2dZv5x1YQO29rxCInZYHwqWtdaNV+m4byz6FJkFR1DTTk7iMf35e1Uk2d54aVsMqBd JBwtMr9+LFIzgkx67gfTzbCRnA5gzaybF8uI0IMWdH909gulpdVaZ7xBsf0QSZlDg8 f32LC+8/WDDzpJbDJO4n0zZN780wQaar13WE2vDProrJcy8E8hTg7JxSHzPTnqnXyR BmnIm4nL+W6zM0zZMivfkwLOsTFJthg5+v6huhdaKGbgfnaJ1DgZlHh48Paupj3OXG yTeu6fNj0NfWQ== Date: Wed, 1 Mar 2023 20:46:02 -0800 From: Jakub Kicinski To: Thorsten Leemhuis Cc: Joe Perches , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Kai =?UTF-8?B?V2Fzc2VyYsOkY2g=?= , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] checkpatch: warn when Reported-by: is not followed by Link: Message-ID: <20230301204602.5e9bf3c0@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jan 2023 13:35:19 +0100 Thorsten Leemhuis wrote: > From: Kai Wasserb=C3=A4ch >=20 > Encourage patch authors to link to reports by issuing a warning, if > a Reported-by: is not accompanied by a link to the report. Those links > are often extremely useful for any code archaeologist that wants to know > more about the backstory of a change than the commit message provides. > That includes maintainers higher up in the patch-flow hierarchy, which > is why Linus asks developers to add such links [1, 2, 3]. To quote [1]: Is it okay if we exclude syzbot reports from this rule? If full syzbot report ID is provided - it's as good as a link.=20 And regression tracking doesn't seem to happen much on syzbot=20 reports either. I like the addition otherwise, it's already catching missing links=20 in netdev land!