Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB349C678D4 for ; Thu, 2 Mar 2023 07:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbjCBHTX (ORCPT ); Thu, 2 Mar 2023 02:19:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbjCBHTI (ORCPT ); Thu, 2 Mar 2023 02:19:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E63C9748 for ; Wed, 1 Mar 2023 23:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677741500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F12kahWtOFJrO7q/fNj60L3hA1t3glM+0zNu7+gdaa0=; b=cHcLVc2u4fctOrFJIyjnkI4M/4LC5WW4KnMWY6OEN7dN5E+gKQ4oW8Lz0Pqex+2MIug3SF x3D73VStJEUd7ykj/XGlCRjHUzWADvKRz6TCRT+ruXcwte0SbnZYGpz5QlLvrGTsKZdRVH uT5J2rprWQfWX48nlf5R98djS2Ax2gA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-597-2pqNpCuWPLemdyy0ow3BbA-1; Thu, 02 Mar 2023 02:18:17 -0500 X-MC-Unique: 2pqNpCuWPLemdyy0ow3BbA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C56485CCE0; Thu, 2 Mar 2023 07:18:16 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D747FC16028; Thu, 2 Mar 2023 07:18:15 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 650531800084; Thu, 2 Mar 2023 08:18:14 +0100 (CET) Date: Thu, 2 Mar 2023 08:18:14 +0100 From: Gerd Hoffmann To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Chia-I Wu , Ryan Neph , Dmitry Osipenko , Daniel Vetter , Rob Clark , Javier Martinez Canillas , David Airlie , Gurchetan Singh , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH v5] drm/virtio: Add option to disable KMS support Message-ID: <20230302071814.ytndjg7txdvxqzcz@sirius.home.kraxel.org> References: <20230301185432.3010939-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230301185432.3010939-1-robdclark@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > + if (vgdev->num_scanouts) { > + ret = virtio_gpu_modeset_init(vgdev); The call to virtio_gpu_modeset_fini() in the unregister code path needs this too. Otherwise the patch looks good to me, so with that fixed: Acked-by: Gerd Hoffmann take care, Gerd