Date:   Thu, 2 Mar 2023 08:39:17 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Guenter Roeck <linux@roeck-us.net>,
        Kuniyuki Iwashima <kuniyu@amazon.com>
Cc:     Slade Watkins <srw@sladewatkins.net>, Pavel Machek <pavel@denx.de>,
        kuniyu@amazon.com, stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, rwarsow@gmx.de
Subject: Re: [PATCH 5.10 00/19] 5.10.171-rc1 review
Message-ID: <ZABSpbAUYfxqxtBS@kroah.com>
References: <20230301180652.316428563@linuxfoundation.org>
 <Y//Lw/zL168J3spQ@duo.ucw.cz>
 <31339d95-a318-ba2e-fdb0-ea7b102fd6fd@sladewatkins.net>
 <8e32bdd6-652f-f7db-15a0-9647f74275a1@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8e32bdd6-652f-f7db-15a0-9647f74275a1@roeck-us.net>
Precedence: bulk

On Wed, Mar 01, 2023 at 09:03:51PM -0800, Guenter Roeck wrote:
> On 3/1/23 14:09, Slade Watkins wrote:
> > On 3/1/23 17:03, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > This is the start of the stable review cycle for the 5.10.171 release.
> > > > There are 19 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > 
> > > AFAICT we should not need this patch -- we don't have b5fc29233d28 in
> > > 5.10, so the assertion seems to be at the correct place here.
> > 
> > This (b5fc29233d28be7a3322848ebe73ac327559cdb9) appears to be in linux-5.10.y,
> > though?
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.10.y&id=b5fc29233d28be7a3322848ebe73ac327559cdb9
> > 
> > Confused,
> > -- Slade
> > 
> 
> Also confused. My script tells me that it is _not_ in v5.10.y, and that it isn't
> queued either.
> 
> Upstream commit b5fc29233d2 ("inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().")
>   Integrated in v6.2-rc1
>   Not in 6.1.y
>   Not in 5.15.y
>   Not in 5.10.y
>   Not in 5.4.y
>   Not in 4.19.y
>   Not in 4.14.y
> 
> and:
> 
> $ git describe --contains b5fc29233d28be7a3322848ebe73ac327559cdb9
> v6.2-rc1~99^2~393^2~4
> 
> However, it looks like 62ec33b44e0 is queued everywhere.
> 
> Upstream commit 62ec33b44e0 ("net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill_queues().")
>   Integrated in v6.2
>   Expected to be fixed in 6.1.y with next stable release (sha 29d108dc216d)
>   Expected to be fixed in 5.15.y with next stable release (sha 07c26a42efc3)
>   Expected to be fixed in 5.10.y with next stable release (sha 3ecdc3798eb9)
>   Expected to be fixed in 5.4.y with next stable release (sha a88c26a1210e)
>   Expected to be fixed in 4.19.y with next stable release (sha 60b390c291e9)
>   Expected to be fixed in 4.14.y with next stable release (sha b53a2b4858c2)

Please see the email from Kuniyuki here:
	https://lore.kernel.org/r/20230227205531.12036-1-kuniyu@amazon.com
that should explain this.

The backport to older kernels is here:
	https://lore.kernel.org/r/20230227211548.13923-1-kuniyu@amazon.com

If you all think this should not be in any of these kernels, please let
work with Kuniyuki to figure it out.

thanks,

greg k-h