Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0A6C7EE30 for ; Thu, 2 Mar 2023 08:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbjCBITA (ORCPT ); Thu, 2 Mar 2023 03:19:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbjCBISw (ORCPT ); Thu, 2 Mar 2023 03:18:52 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19037168BE; Thu, 2 Mar 2023 00:18:51 -0800 (PST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 322892we031063; Thu, 2 Mar 2023 08:18:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=OaoBen/kILXiB94wXBfZ7shxCwQxw2u9LfaYcuPIID4=; b=NcgLK1SBhiwxDrcy5CSEGuBsZdGATjmXwMAmqAl67l81spgw/sdzxN1oZ+IOEOpx+6Op rqbcGN4lV1Dlmc38BzIxs8tgKVFMvz1P6UlYE6dQh027QsY78Onu0NPNkEO9Snoy1Bbk AJaAGqWEQ+LWeWkpLAtdE6FSACdrV+dKmGyQJ8hPDtmRzE8jDbjZXr3qnLiNyXYnbxZM UWGzn0WttWFRe1UKp6OkXEATbjRpdDSHC8FHTVbrvuIlnm0krSyTvTcL36H4/qe2ftc0 yEiKmDUw0m36OynpPvKE3kf+BdscUB3Pg01P4qKTQjaLrMYrLpC89bTFCMqGBlMsPdXm wQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p2r1hg0u5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Mar 2023 08:18:14 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3228IDhi018597 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 Mar 2023 08:18:13 GMT Received: from [10.50.55.202] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 2 Mar 2023 00:18:08 -0800 Message-ID: Date: Thu, 2 Mar 2023 13:48:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 04/18] media: venus: firmware: Leave a clue for homegrown porters Content-Language: en-US To: Konrad Dybcio , Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , "Mauro Carvalho Chehab" , Dikshita Agarwal , Bryan O'Donoghue , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek CC: Mauro Carvalho Chehab , Stanimir Varbanov , , , , "Vikash Garodia" References: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> <20230228-topic-venus-v1-4-58c2c88384e9@linaro.org> From: Dikshita Agarwal In-Reply-To: <20230228-topic-venus-v1-4-58c2c88384e9@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fYZMmSmGBDkbkmZc8KGJCvO_ZTQV5it4 X-Proofpoint-GUID: fYZMmSmGBDkbkmZc8KGJCvO_ZTQV5it4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-02_04,2023-03-02_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303020070 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/28/2023 8:54 PM, Konrad Dybcio wrote: > Leave a clue about where the seemingly magic values come from, as it > is not obvious and requires some digging downstream.. > > Signed-off-by: Konrad Dybcio > --- > drivers/media/platform/qcom/venus/firmware.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > index 61ff20a7e935..1bb6406af564 100644 > --- a/drivers/media/platform/qcom/venus/firmware.c > +++ b/drivers/media/platform/qcom/venus/firmware.c > @@ -241,6 +241,13 @@ int venus_boot(struct venus_core *core) > return ret; > > if (core->use_tz && res->cp_size) { > + /* > + * Clues for porting using downstream data: > + * cp_start = 0 > + * cp_size = venus_ns/virtual-addr-pool[0] (yes, addr not size) > + * cp_nonpixel_start = venus_sec_non_pixel/virtual-addr-pool[0] > + * cp_nonpixel_size = venus_sec_non_pixel/virtual-addr-pool[1] > + */ > ret = qcom_scm_mem_protect_video_var(res->cp_start, > res->cp_size, > res->cp_nonpixel_start, reviewed-by: Dikshita Agarwal