From:   "Bumwoo Lee" <bw365.lee@samsung.com>
To:     <myungjoo.ham@samsung.com>,
        "'Chanwoo Choi'" <cw00.choi@samsung.com>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: 
Subject: RE: RE: [PATCH v2 2/4] extcon: Added extcon_alloc_cables to
 simplify extcon register function
Date:   Thu, 2 Mar 2023 17:33:12 +0900
Message-ID: <006f01d94ce1$a0751300$e15f3900$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQMs5Xzd7TX9SfVksmmJQ2eqp0be4gEndo8vAX4NdCIBRRvN4gEPThYuAeHKeESsCP48gIAAGpzg
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <091101d94ca7$a4ad23c0$ee076b40$@samsung.com>
        <20230220054513.27385-3-bw365.lee@samsung.com>
        <20230220054513.27385-1-bw365.lee@samsung.com>
        <20230224100325epcms1p3e8886e278e23f610c8490cb69f1d452d@epcms1p3>
        <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcms1p1>
        <20230302063312epcms1p1e0cd1a2d74dbd3daa4c7b7407b975803@epcms1p1> 
Precedence: bulk


> -----Original Message-----
> From: Bumwoo Lee <bw365.lee=40samsung.com>
> Sent: Thursday, March 2, 2023 4:12 PM
> To: 'myungjoo.ham=40samsung.com' <myungjoo.ham=40samsung.com>; 'Chanwoo C=
hoi'
> <cw00.choi=40samsung.com>; 'linux-kernel=40vger.kernel.org' <linux-
> kernel=40vger.kernel.org>
> Subject: RE: RE: =5BPATCH v2 2/4=5D extcon: Added extcon_alloc_cables to
> simplify extcon register function
>=20
>=20
> > -----Original Message-----
> > From: MyungJoo Ham <myungjoo.ham=40samsung.com>
> > Sent: Thursday, March 2, 2023 3:33 PM
> > To: Bumwoo Lee <bw365.lee=40samsung.com>; Chanwoo Choi
> > <cw00.choi=40samsung.com>; linux-kernel=40vger.kernel.org
> > Subject: RE: RE: =5BPATCH v2 2/4=5D extcon: Added extcon_alloc_cables t=
o
> > simplify extcon register function
> >
> > >
> > >
> > >--------- Original Message ---------
> > >Sender : =EC=9D=B4=EB=B2=94=EC=9A=B0=20<bw365.lee=40samsung.com>Produc=
t=20S/W=20Lab(VD)/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90=20Date=20:=0D=0A>=20=
>=20>2023-03-02=2010:38=20(GMT+9)=20Title=20:=20RE:=20=5BPATCH=20v2=202/4=
=5D=20extcon:=20Added=0D=0A>=20>=20>extcon_alloc_cables=20to=20simplify=20e=
xtcon=20register=20function=0D=0A>=20>=20>=0D=0A>=20>=20>Hello.=0D=0A>=20>=
=20>=0D=0A>=20>=20>As=20you=20can=20see,=20edev->cables=20are=20freed=20if=
=20extcon_alloc_cables()=0D=0A>=20>=20>function=20return=20error=20handling=
=20in=20extcon_dev_register()=20Other=20added=0D=0A>=20>=20functions=20are=
=20also=20same.=0D=0A>=20>=20>=0D=0A>=20>=20>Because=20it's=20functionalize=
d,=20apart=20from=20this,=20do=20you=20want=20to=20mention=0D=0A>=20>=20>th=
at=0D=0A>=20>=20it=20should=20be=20freed=20within=20the=20function?=0D=0A>=
=20>=20>Please=20let=20me=20know=20your=20opinion.=0D=0A>=20>=20>=0D=0A>=20=
>=20>extcon_dev_register(struct=20extcon_dev=20*edev)=7B=20...=0D=0A>=20>=
=20>=0D=0A>=20>=20>=20=20=20=20=20=20=20=20ret=20=3D=20extcon_alloc_cables(=
edev);=0D=0A>=20>=20>=20=20=20=20=20=20=20=20if=20(ret)=0D=0A>=20>=20>=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20goto=20err_alloc_cables;=0D=0A=
>=20>=20>=0D=0A>=20>=20>...=0D=0A>=20>=20>=0D=0A>=20>=20>err_alloc_cables:=
=0D=0A>=20>=20>=20=20=20=20=20=20=20=20=20if=20(edev->max_supported)=0D=0A>=
=20>=20>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20kfree(edev->cabl=
es);=0D=0A>=20>=20>=0D=0A>=20>=20>=0D=0A>=20>=20>Regards,=0D=0A>=20>=20>Bum=
woo=0D=0A>=20>=0D=0A>=20>=20In=20such=20a=20case,=20you=20are=20doing=20kfr=
ee(NULL);=20with=20the=20following:=0D=0A>=20=0D=0A>=20Yes,=20you=20are=20r=
ight.=0D=0A>=20But=20Kfree()=20is=20checking=20NULL=20internally.=20So=20it=
=20does=20not=20a=20problem=20I=20think.=0D=0A>=20Anyway=20I=20added=20kfre=
e(edev->cables)=20before=20exit=20extcon_alloc_cables()=20like=0D=0A>=20bel=
ow=20on=20v3=20patches.=0D=0A>=20=0D=0A>=20static=20int=20extcon_alloc_cabl=
es(struct=20extcon_dev=20*edev)=20=7B=20...=0D=0A>=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20for=20(index--;=20ind=
ex=20>=3D=200;=20index--)=20=7B=0D=0A>=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20cable=20=
=3D=20&edev->cables=5Bindex=5D;=0D=0A>=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20kfree(cab=
le->attr_g.name);=0D=0A>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=7D=0D=0A>=20=0D=0A>=20+=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20kfree(edev->cables);=0D=0A>=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20return=20-ENOMEM;=0D=0A>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=7D=0D=0A>=20=0D=0A=0D=0AIn=20order=20to=20avoid=20unnecessary=20kfre=
e(NULL),=20the=20position=20will=20be=20moved=20like=20below=20on=20v4=20pa=
tch.=0D=0A=0D=0Aerr_alloc_muex:=0D=0A=09for=20(index=20=3D=200;=20index=20<=
=20edev->max_supported;=20index++)=0D=0A=20=20=20=20=20=20=20=20=09kfree(ed=
ev->cables=5Bindex=5D.attr_g.name);=0D=0A+=09if=20(edev->max_supported)=0D=
=0A+=09=09kfree(edev->cables);=0D=0Aerr_alloc_cables:=0D=0A-=09if=20(edev->=
max_supported)=0D=0A-=09=09kfree(edev->cables);=20=0D=0A=20=20=20=20=20=20=
=20=20return=20ret;=0D=0A=0D=0A=0D=0A>=20Regards,=0D=0A>=20Bumwoo=0D=0A=0D=
=0A