Date:   Thu, 2 Mar 2023 09:33:17 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio
 pins into another table
Message-ID: <20230302093317.574c87a1@md1za8fc.ad001.siemens.net>
In-Reply-To: <Y/+JsTpONdhk/nwG@smile.fi.intel.com>
References: <20230301170215.23382-1-henning.schild@siemens.com>
        <20230301170215.23382-2-henning.schild@siemens.com>
        <Y/+JsTpONdhk/nwG@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i90AdNELIiBjcSxeV+iFUsXACCDRFMXAnZVBKK4tLYi871j9hF3+IpoVBb4/?=
 =?us-ascii?Q?rwh3YtCzR6JP+Dnpg0dkBuzcptnc6dcNeSm5sGsPqg4Nt3+QH4hfcCwzySzL?=
 =?us-ascii?Q?HAqCl5FzHjh8iiK5xuJG5YzJJ3GLrVzkq6QlGPOdt2hUJc8m8DvbEAxM59f1?=
 =?us-ascii?Q?5o7V5yHjYRikJL+6GVjuUNlRJ5pQqPYzJJ3Mm6twgi2XnWIiSAQEV87zyr7k?=
 =?us-ascii?Q?PDdBF8XQ5Yy1JiHtPw0dd++bG5nUmRkK8ac+PveZdb6MmJ0FPjwbqf1OenBy?=
 =?us-ascii?Q?7xsgGyPkAYPeiE5UYl+0gXXGfCL1+PjvBi9M1IF1ZtIfWa48Cvzft8Go8zkd?=
 =?us-ascii?Q?OGP1G3Z6Iro4nt6cdMrt+wDziz/dKX+uSOwrTsn2v6azvkyM/goqTh/L+/OI?=
 =?us-ascii?Q?zx6Y8uxYMU57kBb3SZRTUCqUuKiGhekrTnWPUJHwbE9IUVgY4Rptarudzo/I?=
 =?us-ascii?Q?bZQROT2SolGBFUNddsbtFZ7RoZH+EIZfYu6OgFHqFHrvX5UPksyvXG26sW//?=
 =?us-ascii?Q?p+kulM7+4p8Fvo2U80J2M5PKvwZx91plWL1FvYoxgUoBfHIseHDhahuL0/zq?=
 =?us-ascii?Q?QdEJAE7+oV+2l94K404hSEXPdLp4BXRERNr6htUjt4VkIrZqVMjhxndebRQ7?=
 =?us-ascii?Q?Mk4500cK0xtb5c76ivxkplkLNVVex/c/jRydxWlQtlTYywqjFChtdTa7OGp4?=
 =?us-ascii?Q?zLAwozhU5IhG+Kj6fhsQLvMhOyOXkKLhHvpIR9X44OvoYmkuoO5dUPgQGm2/?=
 =?us-ascii?Q?s1ccFV/lgQzZVsQD3Ka6CQCQX+RyZbOMiF3GxILTxbU7UnqZauQhpxFitf1G?=
 =?us-ascii?Q?4zWFjojOUYRQRDvp2LWRy5R5OUqaN/M6SY0baxuTQQ/fWzDgoMCL61L/mpuG?=
 =?us-ascii?Q?O9ahaY5kFbJnKJlSkawmNvWFZf0Wk0g9E1eU9HCCob9qmkBGOdIUWhckmjay?=
 =?us-ascii?Q?/Y/TcEepgBnGUQDlI+IGDSHa8O0q8zO15uL+AUSRc34RskL8+Ye7A/njEkUB?=
 =?us-ascii?Q?Yv8pnmxmIRuZJmSOltJCXlVX/yH9+iiJL2yUwtcCPV7ceuWrShp+KPaBHDOi?=
 =?us-ascii?Q?CqcNBZQeQykJb3QQle32x8VrzDCITgidt4t6vGdR8ow7MhDvUeox/32qTgNU?=
 =?us-ascii?Q?Jm8jc1+c7McEgQHSdvqbJwOiGy1TGDYXCQKQxWO6bELoMS/PCN923FwuB2OK?=
 =?us-ascii?Q?t5tfa6JYgbThBu162KO8Dzl49U2Uj2BBhjHujITvN0uqPfN+TPoZ5MKflzmW?=
 =?us-ascii?Q?Dx5Rl82vBiA1mIkcv+F3qWrlgGCTcqSxzfCtD+MCVD/wiAlI8cC8Mjw4tvY/?=
 =?us-ascii?Q?cKFBGGvNdBKegxEsmb6q7No0HssxWHhwGItn8FK5GfeyX1/Pn/9DvZNKY4U9?=
 =?us-ascii?Q?M8pczOJphL/TrQcVfy2PJCSG5sMWpQ1ikij6OnrUmBsWOr81L4XlmUGg+WWE?=
 =?us-ascii?Q?75uyuihTtyZQN9RAxCDPxerftzNFJlzSMrq/BmH/CmsrnHsxGLnKU+NHKj2F?=
 =?us-ascii?Q?T3oNDHe3O5gbG2z9AtN1CGN9oh4PKeDfyd53ICQdVjvXAtDNaQMdg/dHDce7?=
 =?us-ascii?Q?TeiKX1K7w9cFOzOJD8Adfeak9uKrtas0RW21K1wFDvgZJ8g3olIxdUbuLn+g?=
 =?us-ascii?Q?kw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c1daf10-1f23-46fd-1120-08db1af8cac1
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 08:33:26.1262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /KqhmAkVn7zoCjm+crkK0fZchxMAFP6uAl7NlPjXA2AkCbOYo8X5kz7A1d4idcWDLM0vvV7llcV+/w2pBoKnVIuIAS2zWCuI+nVezeScCjQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3260
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 1 Mar 2023 19:21:53 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Wed, Mar 01, 2023 at 06:02:13PM +0100, Henning Schild wrote:
> > There are two special pins needed to init the LEDs. We used to have
> > them at the end of the gpiod_lookup table to give to "leds-gpio". A
> > cleaner way is to have a dedicated table for the special pins.  
> 
> ...
> 
> > +	.dev_id = NULL,  
> 
> Technically speaking this is redundant. Maybe you wanted to be more
> explicit with a comment like
> 
> 	.dev_id = NULL,		/* Filled during
> initialization */
> 
> ...
> 
> > +	.dev_id = NULL,  
> 
> Ditto.

Sorry you already pointed that out earlier, it slipped back in with
the rewrite.

Henning