Date:   Thu, 2 Mar 2023 11:10:08 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Alexander Lobakin <aleksander.lobakin@intel.com>
Cc:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND net v1 0/2] iavf: fix double-broken HW hash report
Message-ID: <20230302091008.GA561905@unreal>
References: <20230301115908.47995-1-aleksander.lobakin@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230301115908.47995-1-aleksander.lobakin@intel.com>
Precedence: bulk

On Wed, Mar 01, 2023 at 12:59:06PM +0100, Alexander Lobakin wrote:
> Currently, passing HW hash from descriptors to skb is broken two times.
> The first bug effectively disables hash from being filled at all, unless
> %NETIF_F_RXHASH is *disabled* via Ethtool. The second incorrectly says
> that IPv6 UDP packets are L3, which also triggers CPU hashing when
> needed (the networking core treats only L4 HW hash as "true").
> The very same problems were fixed in i40e and ice, but not in iavf,
> although each of the original commits bugged at least two drivers.
> It's never too late (I hope), so fix iavf this time.
> 
> Alexander Lobakin (2):
>   iavf: fix inverted Rx hash condition leading to disabled hash
>   iavf: fix non-tunneled IPv6 UDP packet type and hashing
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>