Date:   Thu, 2 Mar 2023 11:19:09 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up
Message-ID: <20230302111909.721352cf@md1za8fc.ad001.siemens.net>
In-Reply-To: <Y/+Lvq36nIgIcAIK@smile.fi.intel.com>
References: <20230301170215.23382-1-henning.schild@siemens.com>
        <Y/+Lvq36nIgIcAIK@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9lst1EbkVexqH1NyBaeeeDiZppICSRAlQBXcLWLXv/pVOWrJtZVMg0BFUiYO?=
 =?us-ascii?Q?wwi2Gc6dadrpU0CZD5m7v11/SzosX3Jf9dRfaIm99qc3BQ86iihGMGFyRnn7?=
 =?us-ascii?Q?pasvgleap8syo7I+2A77euNLNS1Li2k1Mw31wZ7crmfb9VOnErMrwov4Uvyj?=
 =?us-ascii?Q?WfytZpfZ9rm5ZFua1qptktw+gbrc+O+f92DFsLagXTLovg8UxwSfSuiApTrR?=
 =?us-ascii?Q?Tw/2ovAdHOZ2vRpjrLVBy2RzHHVAYSIQOyy5vwP3W0KfqdZxVftNWByujd6A?=
 =?us-ascii?Q?yry7a3ZHCJsXae+vH32Xufm+txp9uJT1m0WYwgzL76nO5AldZQmdgjcb9wKK?=
 =?us-ascii?Q?Stc5i0w9qEKj1H2zf288IbXRcXP37rCIpFRThhed/Pj8YqanCnuHTxyhVjvI?=
 =?us-ascii?Q?xyxBKhNNUUyYEY7JnzjDf9MdQ0jHka3bns8oqx1NP41o4dlx/gxEcqgEJ7lM?=
 =?us-ascii?Q?zFBS5w7alzZsVnKh5KoIjsiMaWD4uRvJEBxdZtO6LKEsMQTSg4bWpU4DDHyp?=
 =?us-ascii?Q?xNpdBLr+zFtwrwhW6ORzn7U7O9b/y6UoGX6tb4D7X8VWfIYM7n05mVaGUPIO?=
 =?us-ascii?Q?JEMJNtY9N5p071r9eiM/DXH7xfWdXWRQqySIzmtaBdGgNL0qGfQ46hjZgwoX?=
 =?us-ascii?Q?EOwlA2aCCjJBTCj4DVSyIyXQi5pFD7Tau/jDmUWyznNP3hEOfpgFx4fau8L6?=
 =?us-ascii?Q?d3fa9fcM5zFzR643p7h70BT+dWALn2hB0Te0mafEGIlnoVCY7J48HbLfLDuO?=
 =?us-ascii?Q?n3zhGr7fMHd/0oHrbGM7Q6XZOJ4A1jgoj/L793R7m840t4uhiXQiCGKn0q6T?=
 =?us-ascii?Q?i93bLRSn15gFeS9kEc5Te9BUSGIPiSYdnQtuhxV4WHCWVr29oA7sB7eME5bV?=
 =?us-ascii?Q?YpDPNv8aZ519fjUTgB5/Ck1Wmb2YS/9S/nfnNh1IwIS/1VwjzIt0SyEM6Cwl?=
 =?us-ascii?Q?i98mWHOC0LUJIzdUe/b4gtKCw+a3eOGvCe7FctA8pz1r8ng38AMEiRXTMDsb?=
 =?us-ascii?Q?s/AHsLj7R1PSZvpbRSX1KdiJkys15NT9gFL4LbJ5iVmMcoU7NcLc64c5XjJW?=
 =?us-ascii?Q?RwgPHN3dWKxwayGbgFBTBkmHEo68Q+B/LprwkREUBYEpNSDBb7JEWbhZIUfX?=
 =?us-ascii?Q?yP/348QENuS8zA5wy/SPgk+8EcdX+63vtnITACwL7H3zCJLodTREYaUEi3jN?=
 =?us-ascii?Q?bL3NhR4cJ+i0AwQzPAcwuaUAp+Q4trhA4u03MQf/X5RJJy+ZlupkiCsPao7m?=
 =?us-ascii?Q?9J6iREEIqwXTqjKxPngD8w0USf4+XTJ3UsIWOiyTsyeBQx8J8GjGR3+YaQtm?=
 =?us-ascii?Q?+sYh9/HyxuDTH49zPXi3MOWhUS6BO0hw39BTyO/LU0zWMNs3JhfRky+D4x5x?=
 =?us-ascii?Q?A5FuSspW/U1ltdUaOdYq+H9jKgOHI5JkFp2EpJiim/YVAQ7fPOcVgcBtXkEv?=
 =?us-ascii?Q?iaOIJO3o8EmOJ1Qo/O/Nz5iokqRq74Ra4ds2836xrDGT2htArhNoApl8Gz4Q?=
 =?us-ascii?Q?sTGox5Mc52uhR6JKNbgohfV0N6BfxhLsNBUzrGU4p9l3wLtDR+UDuL3Kti+9?=
 =?us-ascii?Q?ONLhVI2Ecldx57xavBQLqBPlCe7nJaeeuI3qgpzPMOgm1WDmph/g/9gyxkKR?=
 =?us-ascii?Q?43pdN0fo1hZryxrZDdN8Xj8=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d88d2653-b708-451a-246e-08db1b079580
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 10:19:19.2323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TjV8O3OZiDIguhgFimro1j+dj64yM/I+mr1KuefcVcXnM2ExHov8qfiT8Oe3/FgpWuAVweVcDaydaV6qp3JQ2MqltB+9hQABkCd4RsUZPdc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR10MB7418
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 1 Mar 2023 19:30:38 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Wed, Mar 01, 2023 at 06:02:12PM +0100, Henning Schild wrote:
> 
> > This series mainly splits the one GPIO driver into two. The split
> > allows to clearly model runtime and compile time dependencies on
> > the GPIO chip drivers.
> > 
> > p1 is kind of not too related to that split but also prepares for
> > more GPIO based drivers to come.
> > 
> > p2 takes the driver we had and puts some of its content into a
> > -core, to be used by the two drivers.
> > 
> > p3 deals with more fine-grained configuration posibilities and
> > compile time dependencies.
> > 
> > It is based on
> > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO
> > providing driver  
> 
> Thank you for an update.
> Not big issues found (except maybe the Makefile).
> 

The Makefile does work with all Y. So if that was all that was open,
and the rest is just optional improvement. I would be happy if this can
be merged as is, and deal with improvements later.

Thanks!

Henning