References: <20230224200502.391570-1-nmi@metaspace.dk>
 <ZAAPBFfqP671N4ue@T590> <87o7pblhi1.fsf@metaspace.dk>
 <ZABfFW+28Jlxq+Ew@T590> <ZABmAR6Du1tUVEa7@T590>
 <CAFj5m9+o4yNA5rNDA+EXWZthMtB+dOLOW0O788i77=Qn1eJ0qQ@mail.gmail.com>
User-agent: mu4e 1.9.18; emacs 28.2.50
From:   Andreas Hindborg <nmi@metaspace.dk>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     linux-block@vger.kernel.org, Hans Holmberg <Hans.Holmberg@wdc.com>,
        Matias Bjorling <Matias.Bjorling@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        kernel test robot <lkp@intel.com>,
        Jens Axboe <axboe@kernel.dk>,
        open list <linux-kernel@vger.kernel.org>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2] block: ublk: enable zoned storage support
Date:   Thu, 02 Mar 2023 11:07:15 +0100
In-reply-to: <CAFj5m9+o4yNA5rNDA+EXWZthMtB+dOLOW0O788i77=Qn1eJ0qQ@mail.gmail.com>
Message-ID: <87h6v3l9up.fsf@metaspace.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Ming Lei <ming.lei@redhat.com> writes:

> On Thu, Mar 2, 2023 at 5:02=E2=80=AFPM Ming Lei <ming.lei@redhat.com> wro=
te:
>>
>> On Thu, Mar 02, 2023 at 04:32:21PM +0800, Ming Lei wrote:
>> > On Thu, Mar 02, 2023 at 08:31:07AM +0100, Andreas Hindborg wrote:
>> > >
>>
>> ...
>>
>> > >
>> > > I agree about fetching more zones. However, it is no good to fetch u=
p to
>> > > a max, since the requested zone report may less than max. I was
>> >
>> > Short read should always be supported, so the interface may need to
>> > return how many zones in single command, please refer to nvme_ns_repor=
t_zones().
>>
>> blk_zone is part of uapi, maybe the short read can be figured out by
>> one all-zeroed 'blk_zone'?  then no extra uapi data is needed for
>> reporting zones.
>
> oops, we have blk_zone_report data for reporting zones to userspace alrea=
dy,
> see blkdev_report_zones_ioctl(), then this way can be re-used for getting=
 zone
> report from ublk server too, right?

Yes that would be nice. But I did the report_zone command like a read
operation, so we are not currently copying any buffers to user space
when issuing the command, we just rely on the iod. I think it would be
better to use the start_sectors and nr_sectors of the iod instead. Then
we don't have to copy the blk_zone_report. What do you think?

BR Andreas