MIME-Version: 1.0
References: <20230222111213.2241633-1-keguang.zhang@gmail.com>
 <20230222111213.2241633-4-keguang.zhang@gmail.com> <Y/YIlb8axBVVW3VV@surfacebook>
In-Reply-To: <Y/YIlb8axBVVW3VV@surfacebook>
From:   Kelvin Cheung <keguang.zhang@gmail.com>
Date:   Thu, 2 Mar 2023 19:08:44 +0800
Message-ID: <CAJhJPsVUEe8h8an5ywWTjcLSXj3uHyxW7bg8q4=Byp-3CTgL0w@mail.gmail.com>
Subject: Re: [PATCH 3/4] gpio: loongson1: Add DT support
To:     andy.shevchenko@gmail.com
Cc:     linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Feb 22, 2023 at 8:21=E2=80=AFPM <andy.shevchenko@gmail.com> wrote:
>
> Wed, Feb 22, 2023 at 07:12:12PM +0800, Keguang Zhang kirjoitti:
> > This patch adds DT support for Loongson-1 GPIO driver,
> > including the following changes.
> > - Add the of_match_table
> > - Parse the ngpios property
> > - Parse the alias id
>
> Split!
>
> ...
>
> > +     if (of_property_read_u32(dn, "ngpios", &ngpios)) {
> > +             dev_err(dev, "Missing ngpios OF property\n");
> > +             return -ENODEV;
> > +     }
>
> Why?! GPIO library has this already.
>
Will make use of gpiolib and remove this part.

> ...
>
> > +     id =3D of_alias_get_id(dn, "gpio");
> > +     if (id < 0) {
> > +             dev_err(dev, "Couldn't get OF id\n");
> > +             return id;
> > +     }
>
> What is this for?
>
Will remove this part.

> ...
>
> > +     ls1x_gc->gc.base =3D pdev->id * BITS_PER_LONG;
> > -     ls1x_gc->gc.base =3D pdev->id * 32;
>
> No way. This is change makes me thing that initially it's simply wrong. P=
lease,
> just use -1 for the base.
>
Sure. And this is already done by bgpio_init().
So I will simply remove this line.
> ...
>
> > +static const struct of_device_id ls1x_gpio_dt_ids[] =3D {
> > +     { .compatible =3D "loongson,ls1x-gpio", },
>
> Inner comma is not needed.
>
Will do.
> > +     { /* sentinel */ }
> > +};
>
> You missed MODULE_DEVICE_TABLE().
>
Will add MODULE_DEVICE_TABLE().
> --
> With Best Regards,
> Andy Shevchenko
>
>


--=20
Best regards,

Kelvin Cheung