From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git sysv pile
Date:   Thu, 02 Mar 2023 12:31:46 +0100
Message-ID: <9074146.CDJkKcVGEf@suse>
In-Reply-To: <20230302095931.jwyrlgtxcke7iwuu@quack3>
References: <Y/gugbqq858QXJBY@ZenIV> <Y/9duET0Mt5hPu2L@ZenIV>
 <20230302095931.jwyrlgtxcke7iwuu@quack3>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On gioved=EC 2 marzo 2023 10:59:31 CET Jan Kara wrote:
> On Wed 01-03-23 14:14:16, Al Viro wrote:
> > On Wed, Mar 01, 2023 at 02:00:18PM +0100, Jan Kara wrote:
> > > On Wed 01-03-23 12:20:56, Fabio M. De Francesco wrote:
> > > > On venerd=EC 24 febbraio 2023 04:26:57 CET Al Viro wrote:
> > > > > 	Fabio's "switch to kmap_local_page()" patchset (originally after=
 the
> > > > >=20
> > > > > ext2 counterpart, with a lot of cleaning up done to it; as the=20
matter
> > > > > of
> > > > > fact, ext2 side is in need of similar cleanups - calling conventi=
ons
> > > > > there
> > > > > are bloody awful).
> > > >=20
> > > > If nobody else is already working on these cleanups in ext2 followi=
ng
> > > > your
> > > > suggestion, I'd be happy to work on this by the end of this week. I=
=20
only
> > > > need
> > > > a confirmation because I'd hate to duplicate someone else work.
> > > >=20
> > > > > Plus the equivalents of minix stuff...
> > > >=20
> > > > I don't know this other filesystem but I could take a look and see
> > > > whether it
> > > > resembles somehow sysv and ext2 (if so, this work would be pretty=20
simple
> > > > too,
> > > > thanks to your kind suggestions when I worked on sysv and ufs).
> > > >=20
> > > > I'm adding Jan to the Cc list to hear whether he is aware of anybody
> > > > else
> > > > working on this changes for ext2. I'm waiting for a reply from you=
=20
(@Al)
> > > > or
> > > > Jan to avoid duplication (as said above).
> > >=20
> > > I'm not sure what exactly Al doesn't like about how ext2 handles page=
s=20
and
> > > mapping but if you have some cleanups in mind, sure go ahead. I don't=
=20
have
> > > any plans on working on that code in the near term.
> >=20
> > I think I've pushed a demo patchset to vfs.git at some point back in
> > January... Yep - see #work.ext2 in there; completely untested, though.
>=20
> OK, I think your changes to ext2_rename() in PATCH 1 leak a reference and
> mapping of old_page but otherwise I like the patches. So Fabio, if you can
> pick them up and push this to completion, it would be nice. Thanks!
>=20

@Jan,

I was sure you would have liked them :-)
I'm happy to pick them up and push them to completion.

But... when yesterday Al showed his demo patchset I probably interpreted hi=
s=20
reply the wrong way and thought that since he spent time for the demo he=20
wanted to put this to completion on his own.

Now I see that you are interpreting his message as an invite to use them to=
=20
shorten the time...=20

=46urthermore I'm not sure about how I should credit him. Should I merely a=
dd a=20
"Suggested-by:" tag or more consistent "Co-authored-by: Al Viro <...>"? Sin=
ce=20
he did so much I'd rather the second but I need his permission.

@Al,

Can I really proceed with *your* work? What should the better suited tag be=
 to=20
credit you for the patches?

If you can reply today or at least by Friday, I'll pick your demo patchset,=
=20
put it to completion, make the patches and test them with (x)fstests on a=20
QEMU/KVM x86_32 bit VM, with 6GB RAM, running an HIGHMEM64GB enabled kernel.

Thanks,

=46abio