MIME-Version: 1.0
References: <20230302072132.1051590-1-linux@rasmusvillemoes.dk>
In-Reply-To: <20230302072132.1051590-1-linux@rasmusvillemoes.dk>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 2 Mar 2023 08:41:51 -0300
Message-ID: <CAOMZO5DiH1f0u2cs7zKyFU6bMBLHTRpqMFuPCB=T8ZzyJxDT2g@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: freescale: remove generic pin config core support
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 2, 2023 at 4:21=E2=80=AFAM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> No instance of "struct imx_pinctrl_soc_info" sets '.generic_pinconf =3D
> true', so all of this is effectively dead code.
>
> To make it easier to understand the actual code, remove all the unused
> cruft. This effectively reverts a5cadbbb081c ("pinctrl: imx: add
> generic pin config core support").
>
> It was only in use by a single SOC (imx7ulp) for a few releases, and
> the commit message of dbffda08f0e9 ("pinctrl: fsl: imx7ulp: change to
> use imx legacy binding") suggests that it won't be used in the
> future. Certainly no new user has appeared in 20+ releases, and should
> the need arise, this can be dug out of git history again.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Yes, this makes sense:

Reviewed-by: Fabio Estevam  <festevam@gmail.com>