Date:   Thu, 2 Mar 2023 12:20:18 +0000
From:   Mark Brown <broonie@kernel.org>
To:     richard.leitner@linux.dev
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Ladislav Michl <ladis@linux-mips.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Benjamin Bara <benjamin.bara@skidata.com>,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support
Message-ID: <b0a5c0c2-dfbd-460a-af0d-c9d498607d72@sirena.org.uk>
References: <20230302-max9867-v1-0-aa9f7f25db5e@skidata.com>
 <20230302-max9867-v1-3-aa9f7f25db5e@skidata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vZhJFgRVoDnGJw+Q"
Content-Disposition: inline
In-Reply-To: <20230302-max9867-v1-3-aa9f7f25db5e@skidata.com>
Precedence: bulk


--vZhJFgRVoDnGJw+Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@linux.dev wrote:

> +	max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(max9867->mclk))
> +		return PTR_ERR(max9867->mclk);
> +	ret = clk_prepare_enable(max9867->mclk);
> +	if (ret < 0)
> +		dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
> +

Nothing ever disables the clock - we need a disable in the remove path
at least.

--vZhJFgRVoDnGJw+Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQAlIEACgkQJNaLcl1U
h9CpjQf8DCWgZStUPCJltIYPDoRugIPverAChi1iNMKLKqO9Rwi3VF2ulGPf9639
hTE+u7lHCXrsfWLn0BpvQk+RZ4aJTnbTbj9ndDlnSPWStGpcl6pIK4i5S3R7RvYJ
KesklhoL1nRCoBlYpwEdpnfRz6TL0NMo3bsqxHZqhGAxNcXuT/8ylPr3dPWYSljP
FiqTg6fqtBAuXES4A9OxtllOrcYMc5VbvEdNtIOyfVs3gNzJaMiiVX2LUG1t4bS3
6QXssdNh5JQHzZwkwKHE2gKiTHR3i3nK4RNBD9WB//DVCDaPuzPLASiyNz5m72T4
zDHfnV2WYtGr2tKlR82hF3AV8C1vfg==
=YJvp
-----END PGP SIGNATURE-----

--vZhJFgRVoDnGJw+Q--