From:   "Pankaj Dubey" <pankaj.dubey@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Shradha Todi'" <shradha.t@samsung.com>, <lpieralisi@kernel.org>,
        <kw@linux.com>, <robh@kernel.org>, <bhelgaas@google.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <alim.akhtar@samsung.com>,
        <jingoohan1@gmail.com>, <Sergey.Semin@baikalelectronics.ru>,
        <lukas.bulwahn@gmail.com>, <hongxing.zhu@nxp.com>,
        <tglx@linutronix.de>, <m.szyprowski@samsung.com>,
        <jh80.chung@samsung.co>
Cc:     <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <a4bfad9d-b9df-28a5-6bee-5cbbca4dd23f@linaro.org>
Subject: RE: [PATCH 08/16] PCI: samsung: Rename exynos_pcie to samsung_pcie
Date:   Thu, 2 Mar 2023 18:02:01 +0530
Message-ID: <146301d94d03$002ba040$0082e0c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHB3D0FgV9/Br8Y35oSVRdB1anKHwF30rWoAbvCRL0BoFQ7lK7vreOg
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230214121333.1837-1-shradha.t@samsung.com>
        <CGME20230214121436epcas5p1641de02220bea5edb23bc875b6311270@epcas5p1.samsung.com>
        <20230214121333.1837-9-shradha.t@samsung.com>
        <a4bfad9d-b9df-28a5-6bee-5cbbca4dd23f@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: Thursday, February 16, 2023 4:37 PM
> To: Shradha Todi <shradha.t=40samsung.com>; lpieralisi=40kernel.org;
> kw=40linux.com; robh=40kernel.org; bhelgaas=40google.com;
> krzysztof.kozlowski+dt=40linaro.org; alim.akhtar=40samsung.com;
> jingoohan1=40gmail.com; Sergey.Semin=40baikalelectronics.ru;
> lukas.bulwahn=40gmail.com; hongxing.zhu=40nxp.com; tglx=40linutronix.de;
> m.szyprowski=40samsung.com; jh80.chung=40samsung.co;
> pankaj.dubey=40samsung.com
> Cc: linux-pci=40vger.kernel.org; devicetree=40vger.kernel.org; linux-arm-
> kernel=40lists.infradead.org; linux-samsung-soc=40vger.kernel.org; linux-
> kernel=40vger.kernel.org
> Subject: Re: =5BPATCH 08/16=5D PCI: samsung: Rename exynos_pcie to
> samsung_pcie
>=20
> On 14/02/2023 13:13, Shradha Todi wrote:
> > The platform specific structure being used is named exynos_pcie.
> > Changing it to samsung_pcie for making it generic.
> >
> > Suggested-by: Pankaj Dubey <pankaj.dubey=40samsung.com>
> > Signed-off-by: Shradha Todi <shradha.t=40samsung.com>
> > ---
> >  drivers/pci/controller/dwc/pci-samsung.c =7C 190
> > +++++++++++------------
> >  1 file changed, 95 insertions(+), 95 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-samsung.c
> > b/drivers/pci/controller/dwc/pci-samsung.c
> > index d5adf1017a05..be0177fcd763 100644
> > --- a/drivers/pci/controller/dwc/pci-samsung.c
> > +++ b/drivers/pci/controller/dwc/pci-samsung.c
> > =40=40 -23,7 +23,7 =40=40
> >
> >  =23include =22pcie-designware.h=22
> >
> > -=23define to_exynos_pcie(x)	dev_get_drvdata((x)->dev)
> > +=23define to_samsung_pcie(x)	dev_get_drvdata((x)->dev)
> >
> >  /* PCIe APPL registers */
> >  =23define EXYNOS_PCIE_IRQ_PULSE			0x000
> > =40=40 -51,7 +51,7 =40=40
> >  =23define EXYNOS_PCIE_APPL_SLV_ARMISC		0x120
> >  =23define EXYNOS_PCIE_APPL_SLV_DBI_ENABLE	BIT(21)
> >
> > -struct exynos_pcie =7B
> > +struct samsung_pcie =7B
>=20
> No, I don't see benefit of this at all. How we call stuff inside driver i=
s not related
> whether this is for Tesla or Exynos. We could even call it =22pony=22. :)=
 Thus
> renamings just to support new variant of Samsung device is not a good rea=
son.
>=20
Whole intention of this whole series was to make exynos-pcie driver to supp=
ort for all Samsung manufactured SoCs be it Exynos series or custom ASIC su=
ch as fsd, artpect-v8.=20

While doing so, we feel for better readability and conveying better names f=
or files, structs, internal APIs will help developers for understanding and=
 reusing it. For example we know that clock initialization will remain comm=
on (thanks for bulk_clk_xxx APIs) so we kept APIs for handling clocks start=
ing with samsung_clk_xxxx, but if we have to implement two variant of APIs,=
 or struct targeting different platforms it would be good if they have plat=
form specific prefixes. This will help in grep or future code maintenance.=
=20

Though technically all these can be done even without renaming, but if we s=
ee no impact as such, so why not use better names?
> Unless all of the old =22exynos=22 names will be soon needed for some exy=
nos-
> specific variants?
>=20

No we don't have any such plans.

> Best regards,
> Krzysztof