Date:   Thu, 2 Mar 2023 08:57:48 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>
Subject: Re: [PATCH 4/4] dmaengine/idxd: Re-enable kernel workqueue under DMA
 API
Message-ID: <ZACdTG4QZSHF2QRj@nvidia.com>
References: <20230302005959.2695267-1-jacob.jun.pan@linux.intel.com>
 <20230302005959.2695267-5-jacob.jun.pan@linux.intel.com>
 <BN9PR11MB527624EDB9FCD26751C73B128CB29@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB527624EDB9FCD26751C73B128CB29@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4QORlVsWLbQieJ1KfyA8FR6FdE/FIVVxTcwZeC4a4KeSkY9hD3OjtmW8WEd9?=
 =?us-ascii?Q?+Z1+k/KHz+c/UmyagaaqTxIZ9Yx0rsPx1+WQC5i/hCzgZBgsSnwGPZRQjX1B?=
 =?us-ascii?Q?5a2qLjCOabE9KMjaBB07z3RG02cYx+f3thj8GHjQlWAf/ySCNxkGjl6yxh4x?=
 =?us-ascii?Q?DUAyRCfGymQ3eukYd5Q4YqSnkSuM7Dmrlc/hoNJCwoQEExYg2yBAwdD8Wg8z?=
 =?us-ascii?Q?nQBQJHlI4iMAxSbTc9BqOUHfoxtmA2zH9dOF56lYeIfpbQBH76UGaRxuG0y5?=
 =?us-ascii?Q?OWdM6NbB3ttn6hVS1saiyBznknSvWFMTtQ/yPHFZacp+YvdLZn2wWo3e9twj?=
 =?us-ascii?Q?aPZpcMWINzHtk2JZl+lYXrYcjnFUSkf6KyoVbSxmOgicwy4pyWcvHERgxPlT?=
 =?us-ascii?Q?YO4mvzWY3ixPRBc2QihjG9ONkD7fKnRtA2iCy2SPahAWRwZ8EOz7kmswR9kW?=
 =?us-ascii?Q?SSGdOwWZjr2xqN8App8pJIvvaxO5jGjkd3NOHPOwt8q5pHso7sBfjLcYNSQG?=
 =?us-ascii?Q?U0q9I6msBm6AGU7sm+gSSl9ELRTdCRO5w4jEf+zP/aP/7oyNpH6SG4Z1D/5A?=
 =?us-ascii?Q?kUdG8heCiIlDqqSYxqAJQgA6uVpGDynrByBcrKkGShgUXFxEHAzn56sB5Qdj?=
 =?us-ascii?Q?7mLBvqTozSHXbLwmrEoQiTegFoUyN3jFASPJh8AFTnZW63l4FYS9fosqx5rc?=
 =?us-ascii?Q?9HTWbbrEaUxetkk5MZ9+yBRaYgNWGi8Hq7oZuTv+qFKqTN+hMMSb1FpQy3eC?=
 =?us-ascii?Q?AKbhdZWQE1p+/nIIhUmMY2po21IYiEPzK6WNVVtSxctEWA6ufqPPAHOa+xnB?=
 =?us-ascii?Q?rQhLOBvx2n8lMdif4+SeCQz4DHII0nAeBpP3J3NhDG3ewkCKcc3EnybjQ/Lx?=
 =?us-ascii?Q?o0/l9yndJkG3OlDlxVyQ7R8KoDR0YFZ4cRiJWeXH9zVBRkK++OHaW2yM2a8z?=
 =?us-ascii?Q?z0H4TxZRQ5Yq4Yk0cN5QW8LXfF/vMBC2SBtBGikl2jh/lt6u+WchNxijQ11J?=
 =?us-ascii?Q?86i0QpcuUT4iwurl/OGRmVjPuVJ5493p/jIwM8ImmOpUsvUnog48WUBQ46pb?=
 =?us-ascii?Q?B01VqQ39K5v4HZn7qZl3CGnMtRMiRii8/VfAs//8/2RjmlI+pFOEBSCkLXdj?=
 =?us-ascii?Q?k/tMmuU+lRKJeA7gfuTjNQSETuf8Y6xQC2OBAx6b1dFPJeF2cK59NQsNQg5F?=
 =?us-ascii?Q?YNVippbzMLISaPqdNFCuRrm8SUnXbJqcM7afgNsZTUbQ15BlMSlbgTTuKMQM?=
 =?us-ascii?Q?GYrKJ0dY1WsHtJy7cPDxSBrvm0UMCKrLNWhN6CQjBIaHnS8AbBANLFYJY5O8?=
 =?us-ascii?Q?xuogwHqFurYmLFUCwD53HoW4CMq3ibS967C65squI2zw53wBs0hp+PCYOl7r?=
 =?us-ascii?Q?zNU3uVhiJ2BxL5nPDaOLQT3xfWP/NMOtrhw7bYgZjm1Q0sq5lHxvGSQtkIex?=
 =?us-ascii?Q?4NnZ5JEQHnVf36DeepGCDeTzwAaLm533ss0/hxmC1TldvtLASQdIY6XqvitZ?=
 =?us-ascii?Q?t4vXhdxNwnpHK/o6ArrEC9FoM8akhaXY6z/qz7HprGjE1Z2MKRKjB6OF4CKW?=
 =?us-ascii?Q?PbNAzLiehvafNMMa3zcmJL1r707VfT7jBxbcuOGf?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c155d91-1fe2-453d-1767-08db1b1dbae5
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 12:57:50.8522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bi4JQZF0lcEyPwAL6WOqmZrqJN5k/ZYUvEkM+fhhhtv6tVNMERxdUFVHyVBVQlm9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5288
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 02, 2023 at 09:47:00AM +0000, Tian, Kevin wrote:
> > From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Sent: Thursday, March 2, 2023 9:00 AM
> > 
> >  static int idxd_enable_system_pasid(struct idxd_device *idxd)
> >  {
> > -	return -EOPNOTSUPP;
> > +	struct pci_dev *pdev = idxd->pdev;
> > +	struct device *dev = &pdev->dev;
> > +	struct iommu_domain *domain;
> > +	union gencfg_reg gencfg;
> > +	ioasid_t pasid;
> > +	int ret;
> > +
> > +	domain = iommu_get_domain_for_dev(dev);
> > +	if (!domain || domain->type == IOMMU_DOMAIN_BLOCKED)
> > +		return -EPERM;
> 
> what about UNMANAGED?

Why are we checking this anyhow?

Get the domain the DMA API is using and feed it to
iommu_attach_device_pasid(). If the driver can't mirror the DMA API's
domain onto the PASID then it will just fail the attach. A domain
cannot even be NULL on x86.

Jason