MIME-Version: 1.0
References: <20220717181000.1186373-1-aford173@gmail.com> <20220717181000.1186373-5-aford173@gmail.com>
 <20220718053721.GB7333@pengutronix.de>
In-Reply-To: <20220718053721.GB7333@pengutronix.de>
From:   Adam Ford <aford173@gmail.com>
Date:   Thu, 2 Mar 2023 07:28:28 -0600
Message-ID: <CAHCN7xKKtCp52XVHd8_-+EvPvsx9hewsEdce=hsLov-0TY9dZA@mail.gmail.com>
Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-beacon: Enable Digitial Microphone
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 18, 2022 at 12:37=E2=80=AFAM Sascha Hauer <s.hauer@pengutronix.=
de> wrote:
>
> Hi Adam,
>
> On Sun, Jul 17, 2022 at 01:09:58PM -0500, Adam Ford wrote:
> > There is a PDM microphone port on the baseboard which is connected to t=
he
> > micfil controller.  Create a new sound card to support this interface.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi=
 b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > index 03266bd90a06..16444954f873 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > @@ -98,7 +98,7 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> >               enable-active-high;
> >       };
> >
> > -     sound {
> > +     sound-codec {
> >               compatible =3D "fsl,imx-audio-wm8962";
> >               model =3D "wm8962-audio";
> >               audio-cpu =3D <&sai3>;
> > @@ -111,6 +111,18 @@ sound {
> >                       "AMIC", "MICBIAS",
> >                       "IN3R", "AMIC";
> >       };
> > +
> > +     sound-micfil {
> > +             compatible =3D "fsl,imx-audio-card";
> > +             model =3D "imx-audio-micfil";
> > +             pri-dai-link {
> > +                     link-name =3D "micfil hifi";
> > +                     format =3D "i2s";
> > +                     cpu {
> > +                             sound-dai =3D <&micfil>;
> > +                     };
> > +             };
> > +     };
>
> Note the micfil works well with the simple-audio-card driver which might
> be an alternative here.

Sascha,

Sorry to resurrect an old thread.

I tried using the simple-audio-card, but it doesn't present me with an
audio card.  I don't get errors, but I don't get a card either.  Can
you point me to an example where someone did this?  I added debug code
to the simple-audio-card and I migrated an existing card, and I see
the debug code for the wm8962 CODEC, but not the micfil.  The Micfil
works just fine with the imx-audio-card, but I don't mind using the
simple-audio-card if it makes more sense.

adam
>
> Sascha
>
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  =
|
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|