Date:   Thu, 2 Mar 2023 13:52:01 +0000
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     "lihuisong (C)" <lihuisong@huawei.com>
Cc:     robbiek@xsightlabs.com, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, rafael@kernel.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        rafael.j.wysocki@intel.com, wanghuiqiang@huawei.com,
        zhangzekun11@huawei.com, wangxiongfeng2@huawei.com,
        tanxiaofei@huawei.com, guohanjun@huawei.com, xiexiuqi@huawei.com,
        wangkefeng.wang@huawei.com, huangdaode@huawei.com
Subject: Re: [PATCH 1/2] mailbox: pcc: Add processing platform notification
 for slave subspaces
Message-ID: <20230302135201.c2qbvtx6k5mgnobv@bogus>
References: <20221016034043.52227-1-lihuisong@huawei.com>
 <20230216063653.1995-1-lihuisong@huawei.com>
 <20230216063653.1995-2-lihuisong@huawei.com>
 <20230301132413.p6ssnkp76pv2bz5y@bogus>
 <de87d0f6-572d-c7be-cf8e-f80914270a9f@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de87d0f6-572d-c7be-cf8e-f80914270a9f@huawei.com>
Precedence: bulk

On Thu, Mar 02, 2023 at 09:57:35AM +0800, lihuisong (C) wrote:
> 
> 在 2023/3/1 21:24, Sudeep Holla 写道:

[...]

> > 
> > +static bool pcc_mbox_cmd_complete_check(struct pcc_chan_info *pchan)
> > +{
> > +       u64 val;
> > +       int ret;
> > +
> > +       ret = pcc_chan_reg_read(&pchan->cmd_complete, &val);
> > +       if (ret)
> > +               return false;
> > +
> 
> we indeed already check if cmd_complete register is exist.
> IMO, it can simply the code logic and reduce the risk of problems if we
> return true here for the type without this register.
> what do you think?
>

IIUC, your concern is about returning true for type 4 when the register
doesn't exist, right ?

I am saying it won't happen as we bail out if there is no GAS register
from pcc_chan_reg_init(). Or am I missing something here ?

> > +       val &= pchan->cmd_complete.status_mask;
> > +
> > +       /*
> > +        * If this is PCC slave subspace channel, then the command complete
> > +        * bit 0 indicates that Platform is sending a notification and OSPM
> > +        * needs to respond this interrupt to process this command.
> > +        */
> > +       if (pchan->type == ACPI_PCCT_TYPE_EXT_PCC_SLAVE_SUBSPACE)
> > +               return !val;
> > +       else
> > +               return !!val;
> This else branch is not applicable to type 3. type 3 will cannot respond
> interrupt.

Sorry I don't understand what you mean by that.

-- 
Regards,
Sudeep