MIME-Version: 1.0
References: <cover.1677750859.git.mazziesaccount@gmail.com> <874d59be98703bb58a98fea72138de5b94d71a52.1677750859.git.mazziesaccount@gmail.com>
In-Reply-To: <874d59be98703bb58a98fea72138de5b94d71a52.1677750859.git.mazziesaccount@gmail.com>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
Date:   Thu, 2 Mar 2023 16:17:28 +0200
Message-ID: <CANhJrGOnG0r+t02wGHfbwqJh6k7xVE=1ah=w4m0s9JjqAGV-9w@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] iio: light: ROHM BU27034 Ambient Light Sensor
To:     Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Paul Gazzillo <paul@pgazz.com>,
        Zhigang Shi <Zhigang.Shi@liteon.com>,
        Shreeya Patel <shreeya.patel@collabora.com>,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

to 2. maalisk. 2023 klo 12.59 Matti Vaittinen
(mazziesaccount@gmail.com) kirjoitti:
>
> ROHM BU27034 is an ambient light sesnor with 3 channels and 3 photo diodes
> capable of detecting a very wide range of illuminance. Typical application
> is adjusting LCD and backlight power of TVs and mobile phones.
>
> Add initial  support for the ROHM BU27034 ambient light sensor.
>
> NOTE:
>         - Driver exposes 4 channels. One IIO_LIGHT channel providing the
>           calculated lux values based on measured data from diodes #0 and
>           #1. Additionally 3 IIO_INTENSITY channels are emitting the raw
>           register data from all diodes for more intense user-space
>           computations.
>         - Sensor has adjustible GAIN values ranging from 1x to 4096x.
>         - Sensor has adjustible measurement times 5, 55, 100, 200 and
>           400 mS. Driver does not support 5 mS which has special
>           limitations.
>         - Driver exposes standard 'scale' adjustment which is
>           implemented by:
>                 1) Trying to adjust only the GAIN
>                 2) If GAIN adjustment only can't provide requested
>                    scale, adjusting both the time and the gain is
>                    attempted.
>         - Driver exposes writable INT_TIME property which can be used
>           for adjusting the measurement time. Time adjustment will also
>           cause the driver to adjust the GAIN so that the overall scale
>           is not changed.
>         - Runtime PM is not implemented.
>         - Driver starts the measurement on the background when it is
>           probed. This improves the respnse time to read-requests

Seems like I forgot to update the commit message. Note to self: change
this when preparing the v3

,,,

> +config ROHM_BU27034
> +       tristate "ROHM BU27034 ambient light sensor"
> +       depends on I2C
> +       select REGMAP_I2C
> +       select IIO_GTS_HELPER

And, judging some other fixes - it seems this one would also need the
select IIO_BUFFER and IIO_KFIFO_BUF now...


-- 

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Discuss - Estimate - Plan - Report and finally accomplish this:
void do_work(int time) __attribute__ ((const));