MIME-Version: 1.0
References: <20230301193403.1507484-1-surenb@google.com> <ZACrgV4f39P/2sZO@dhcp22.suse.cz>
In-Reply-To: <ZACrgV4f39P/2sZO@dhcp22.suse.cz>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 2 Mar 2023 08:08:38 -0800
Message-ID: <CAJuCfpH+yuynm+8LDbcOyh-q_PFTOz-FygxO9aSg8=RUR3LT+Q@mail.gmail.com>
Subject: Re: [PATCH 1/1] psi: remove 500ms min window size limitation for triggers
To:     Michal Hocko <mhocko@suse.com>
Cc:     tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com,
        peterz@infradead.org, johunt@akamai.com, keescook@chromium.org,
        quic_sudaraja@quicinc.com, cgroups@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 2, 2023 at 5:58 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Wed 01-03-23 11:34:03, Suren Baghdasaryan wrote:
> > Current 500ms min window size for psi triggers limits polling interval
> > to 50ms to prevent polling threads from using too much cpu bandwidth by
> > polling too frequently. However the number of cgroups with triggers is
> > unlimited, so this protection can be defeated by creating multiple
> > cgroups with psi triggers (triggers in each cgroup are served by a single
> > "psimon" kernel thread).
> > Instead of limiting min polling period, which also limits the latency of
> > psi events, it's better to limit psi trigger creation to authorized users
> > only, like we do for system-wide psi triggers (/proc/pressure/* files can
> > be written only by processes with CAP_SYS_RESOURCE capability). This also
> > makes access rules for cgroup psi files consistent with system-wide ones.
> > Add a CAP_SYS_RESOURCE capability check for cgroup psi file writers and
> > remove the psi window min size limitation.
> >
> > Suggested-by: Sudarshan Rajagopalan <quic_sudaraja@quicinc.com>
> > Link: https://lore.kernel.org/all/cover.1676067791.git.quic_sudaraja@quicinc.com/
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> with this to fix
> [...]
> > @@ -1278,8 +1277,7 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
> >       if (state >= PSI_NONIDLE)
> >               return ERR_PTR(-EINVAL);
> >
> > -     if (window_us < WINDOW_MIN_US ||
> > -             window_us > WINDOW_MAX_US)
> > +     if (window_us <= 0 || window_us > WINDOW_MAX_US)
> >               return ERR_PTR(-EINVAL);
>
> window_us is u32 sp the check for <= 0 doesn't make any sense.

Completely missed that. Will change to == 0 and post the new version.
window_us is later multiplied by NSEC_PER_USEC and then divided by
UPDATES_PER_WINDOW(10), so even the smallest value of 1 still results
in a positive poll_min_period. I think we should be fine with that
check.
Thanks!

>
> >
> >       /* Check threshold */
> > --
> > 2.40.0.rc0.216.gc4246ad0f0-goog
>
> --
> Michal Hocko
> SUSE Labs